On 2013-03-14 12:26, Markus Blatt wrote:
This means if the modules is name FindSuperLU.cmake (as in DUNE), the
variable is CMAKE_DISABLE_FIND_PACKAGE_SuperLU. Unfortunately, the
module in opm-core is called FindSUPERLU.cmake.
Can we decide on a common naming scheme? According to its website
the package name is SuperLU and as other modules (e.g. TinyXML)
adhere to this camelcase rule we should probably use
FindSuperLU.cmake and change the variable name in configure.
I totally concur.
I originally renamed the module FindSuperLU => FindSUPERLU since all the
variables it set were in uppercase, so it fitted into the scheme of OpmFind.
However, this is a problem that more than one module have, so the right
thing to do here is to allow uppercase variables as well. Thus, the
module should be renamed back to maintain DUNE<=>OPM consistency. I have
a pull-request in queue for that one.
(BTW; you probably want the lib32/64 and PREFIX/ROOT patches to
FindSuperLU; sorry for not getting around to upstreaming them yet)
--
Roland.
_______________________________________________
Opm mailing list
[email protected]
http://www.opm-project.org/mailman/listinfo/opm
