Since I confess to be guilty of having started this, I guess you should be aware of my position as well:
Good - thank you. I think that it is beneficial to catch errors which are caused by trying to assign a default value to non-defaultable items as soon as the issue is detected. My main points are that this makes the code more robust (because the binary won't crash after possibly hours of execution if it suddenly tries do accessing such an invalid item) and it makes the higher level code simpler and easier to maintain (because it can rely on the fact that all non-defaultable items are present after the deck has been successfully parsed). The phrase: "because the binary won't crash after possibly hours of execution if it suddenly tries do accessing such an invalid item" is quite misleading for my position; if an item without default is missing it should raise an exception when forming the EclipseState - i.e. a long time before any simulation has started. However - the underlying assumption behind that argument (which I had frankly forgotten) is of course that all higher level code is accessing the deck properties through the EclipseState object and not the deck directly. That is certainly the direction I want to move things - but we are not there yet. Joakim ------------------------------------------------------------------- The information contained in this message may be CONFIDENTIAL and is intended for the addressee only. Any unauthorised use, dissemination of the information or copying of this message is prohibited. If you are not the addressee, please notify the sender immediately by return e-mail and delete this message. Thank you
_______________________________________________ Opm mailing list [email protected] http://www.opm-project.org/mailman/listinfo/opm
