Hi Ryota, As you mentioned tempest, do you mean that we run doctor test as a tempest plugin?
BR, dwj Ryota Mibu <[email protected]> 2016-11-22 12:35 收件人 Yujun Zhang <[email protected]>, "[email protected]" <[email protected]> 抄送 TECH-DISCUSS OPNFV <[email protected]> 主题 RE: [opnfv-tech-discuss] [doctor] question on code refactoring task (DOCTOR-71) Yujun, I agree, I’m open to change language if we have an alternative works fine in the team. As far as I know, there is no rule and guideline for code language in OPNFV. If we consider that we should work closer with OpenStack, we should use python and tempest. The separation of testing code would still make sense if we change the language later on. BR, Ryota From: [email protected] [mailto:[email protected]] On Behalf Of Yujun Zhang Sent: Thursday, November 17, 2016 3:39 PM To: [email protected] Cc: [email protected]; TECH-DISCUSS OPNFV <[email protected]> Subject: Re: [opnfv-tech-discuss] [doctor] question on code refactoring task (DOCTOR-71) Wenjuan, A README for the overview of your design would help reviewers to understand the huge chunk of code. On Thu, Nov 17, 2016 at 12:33 PM <[email protected]> wrote: Hi All, I agree that we should discuess more about how to refactor the test script to let it become more modular, readable and maintainable. The programming languages is the first step. I propsed a framwork about the refactor the test script[1]. This is my init ideal, any comments are welcome. :) [1]https://github.com/openzero-zte/doctor_test_refactor BR. dwl Yujun Zhang <[email protected]> 发件人: [email protected] 2016-11-17 09:48 收件人 TECH-DISCUSS OPNFV <[email protected]> 抄送 主题 [opnfv-tech-discuss] [doctor] question on code refactoring task (DOCTOR-71) Hi, doctors, Carlos has started code refactoring of the test script[1]. It looks good to separate common function and installer specific function into different modules and improve the readability of main script.[2][3] I just have some concerns about the future complexibility of this test script. We are going to handle a multidimensional matrix of test condition, i.e. N installers * M inspectors * K notifiers * ... I'm not sure shell script can handle it well and provide a user friendly way for debugging, profiling[4] and reporting. No intention to start another war between programming languages. But this is something we need to consider before going deep in code refactoring. [1]: https://jira.opnfv.org/browse/DOCTOR-71 [2]: https://gerrit.opnfv.org/gerrit/#/c/24395/ [3]: https://gerrit.opnfv.org/gerrit/#/c/24399/ [4]: https://jira.opnfv.org/browse/DOCTOR-72 _______________________________________________ opnfv-tech-discuss mailing list [email protected] https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
_______________________________________________ opnfv-tech-discuss mailing list [email protected] https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
