+2 for gate check instead of reminding by Email. It seems Ray has used another tool for license scanning. Luke Hinds <[email protected]>于2017年2月19日 周日06:32写道：
> If its useful we could add something to our gate to check for license > text? We are trailing a system that checks for private keys, secrets and > blobs being pushed to repos, I could look to extend this to perform a > license check too? > > On Sat, Feb 18, 2017 at 5:27 PM, Yujun Zhang (ZTE) < > [email protected]> wrote: > > The script works great in qtip repo[1]. Thanks a lot, Justin. > > A few comments for improvements > > > 1. add license to this script itself so people know how to contribute. > By default, it is proprietary. > 2. ignore __init__.py as indicated in OPNFV contribution > guidelines[2]. A workaround is `git checkout **/__init__.py` after > processing. > 3. use company name mapping in stackalytics[3]. I believe it covers > most contributors in OPNFV > 4. rename the the repo. It is strange to fork a repo named Lab to > other account. > > > [1]: https://gerrit.opnfv.org/gerrit/#/c/29029/ > [2]: https://wiki.opnfv.org/display/DEV/Contribution+Guidelines > [3]: > http://git.openstack.org/cgit/openstack/stackalytics/tree/etc/default_data.json#n23439 > > On Fri, Feb 17, 2017 at 10:52 AM gang chi <[email protected]> > wrote: > > Hi, > > I think most of team has received mail from Ray who told me there are over > hundred files without License in Compass4nfv repo. I think some team may > have same issue with me. > so I share my script to generate license header for OPNFV repos. > > https://github.com/Justin-chi/Lab/blob/master/add_license.sh > > Here is result of the script: https://gerrit.opnfv.org/gerrit/#/c/28885/ > > Hope it will works for you. > > Regards > Justin > _______________________________________________ > opnfv-tech-discuss mailing list > [email protected] > https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss > > -- > Yujun Zhang > > _______________________________________________ > opnfv-tech-discuss mailing list > [email protected] > https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss > > > > > -- > Luke Hinds | NFV Partner Engineering | Office of Technology | Red Hat > e: [email protected] | irc: lhinds @freenode | m: +44 77 45 63 98 84 | t: +44 > 12 52 36 2483 > -- Yujun Zhang
_______________________________________________ opnfv-tech-discuss mailing list [email protected] https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
