Hi Trevor, I like the idea. From a Dovetail perspective, we have already created a group in Gerrit some time ago to simplify the process of adding all reviewers to a patch. Automating this process is even better. So, once the plugin is installed, we would make use of it.
Best regards Georg > -----Original Message----- > From: opnfv-tech-discuss-boun...@lists.opnfv.org [mailto:opnfv-tech- > discuss-boun...@lists.opnfv.org] On Behalf Of Trevor Bramwell > Sent: Tuesday, April 17, 2018 1:33 AM > To: opnfv-...@lists.opnfv.org; opnfv-tech-discuss@lists.opnfv.org > Cc: infra...@lists.opnfv.org > Subject: [opnfv-tech-discuss] Gerrit Reviewers Plugin > > Hi All, > > The XCI team requested the gerrit-reviewers[1] plugin be installed on the > OPNFV Gerrit server, and this morning the Infra-WG agreed[2] to the > request. I wanted to give some context on what the plugin does and provide > time to hear any concerns or feedback at the next TSC meeting. > > Simply put: gerrit-reviewers plugin allows you to automatically add reviewers > to patchsets. > > This is configured on a per-project basis through a 'reviewers.config' > file. As projects don't have access to where this file is stored, they'll > need to > send a request to helpd...@opnfv.org in order to have the configuration > added. > > For example, for the releng-xci project this file would look like: > > [filter "*"] > reviewer = xci > > 'xci' here is a group defined in Gerrit, and everyone in the xci group would > automatically be added to any new patches created in the releng-xci repo. > > Something else the plugin allows is for defining a 'reviewers.config' > file in the All-Projects repo, which gets inheritied to every project. > > This would all us to do something like: > > [filter "file:^docs/.*"] > reviewer = docs-reviewers > > Where changes to any projects docs would automatically have a docs- > reviewers group added to the patchset. I'm not proposing this idea, just > giving an example of one way we could take advantage of it. > > One issue currently with the plugin is that it doesn't allow for using LDAP > groups. This means each project that would like to use it will also need to > have a corresponding group created for them. We're (the LF Releng team) is > looking at ways we might automate creating these groups, but for now > they'd have been be manually created. > > Our plan is to install this plugin after the intial Fraser release as it will > require a > brief restart to Gerrit. > > Please reply if you have concerns or questions or bring them to next TSC > meeting. > > Regards, > Trevor Bramwell > > [1] > https://gerrit.googlesource.com/plugins/reviewers/+doc/master/src/main/r > esources/Documentation/config.md > [2] http://meetbot.opnfv.org/meetings/opnfv-meeting/2018/opnfv- > meeting.2018-04-16-14.58.html _______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
