Hi, No worries.
Yes, you should create a new patch set to your original review (https://gerrit.opnfv.org/gerrit/#/c/58959/). If I see it correctly you did your modifications directly to the master branch, so I guess all the different changes are in different directories. To add your update to the original review you should: 1. Go to the repo directory from where the original change was added (if you donot have it anymore than go to a repo directory with an unmodified master branch (or clone one down) and issue git review -d 58959) 2. Add your updates there. You should not add the things in my change (https://gerrit.opnfv.org/gerrit/#/c/59763/) I will merge these in once your change is in the master. 3. Add your files with git add. 4. Commit git commit –amend 5. Add to the reivew with git review 6. You can simply abandon the two new changes (https://gerrit.opnfv.org/gerrit/#/c/60451/ and https://gerrit.opnfv.org/gerrit/#/c/60453/) If it is not working I can add your changes from the two new changes to the original one. Br, Gerg0 From: 赵奇慧 <[email protected]> Sent: Wednesday, August 1, 2018 6:35 AM To: Csatari, Gergely (Nokia - HU/Budapest) <[email protected]>; fuqiao <[email protected]>; rsblendido <[email protected]>; georg.kunz <[email protected]>; tim.irnich <[email protected]>; ildiko <[email protected]> Cc: trevor.cooper <[email protected]>; periyasamy.palanisamy <[email protected]>; mbuil <[email protected]>; zhang.jun3g <[email protected]>; opnfv-tech-discuss <[email protected]> Subject: Re: Re: Re: [opnfv-tech-discuss] [edge cloud] updating requirements for review Hello Gergely, Sorry I didn't update the requirement document in time, cause I was quite buzy last week. And thank you so much for your kind help on this document ;) The newest version of requriements has been uploaded here: https://gerrit.opnfv.org/gerrit/#/c/60453/ But I'm still having some problems with the git operations and need you help. I think the new requirements doc should be uploaded as a new patch to the original subject, instead of creating a new subject. But I don't know how to do that. Could you please help me with this? And I mistakenly committed and pushed the change twice, one of which is named "sign-off-by: qihuiz......", and this one should be removed. I tried to revert it, but it seems not working. Could you please help me with these two problems? Sorry for making you some extra work~~ Thank you again~~and look forward to your reply ~~ Best, Qihui China Mobile Research Institute Department of Network Technology Mobile: 13810659120 发件人: 赵奇慧<mailto:[email protected]> 时间: 2018/08/01(星期三)11:22 收件人: Gergely Csatari<mailto:[email protected]>;fuqiao<mailto:[email protected]>;rsblendido<mailto:[email protected]>;georg.kunz<mailto:[email protected]>;tim.irnich<mailto:[email protected]>;ildiko<mailto:[email protected]>; 抄送人: trevor.cooper<mailto:[email protected]>;periyasamy.palanisamy<mailto:[email protected]>;mbuil<mailto:[email protected]>;zhang.jun3g<mailto:[email protected]>;opnfv-tech-discuss<mailto:[email protected]>; 主题: Re: Re: [opnfv-tech-discuss] [edge cloud] updating requirements for review Hello edge cloud team, Sorry for the late update on the requirements document. It has already been uploaded here for review: https://gerrit.opnfv.org/gerrit/#/c/60453/ . Thank you so much for your patient~~ Hoping my uploading and git commit operations are correct, cause I'm still a bit confused about this. If something is wrong, please feel free to correct me. Thanks a lot~~ Best， Qihui China Mobile Research Institute Department of Network Technology Mobile: 13810659120 发件人: Gergely Csatari<mailto:[email protected]> 时间: 2018/07/26(星期四)15:15 收件人: fuqiao<mailto:[email protected]>;rsblendido<mailto:[email protected]>;georg.kunz<mailto:[email protected]>;tim.irnich<mailto:[email protected]>;ildiko<mailto:[email protected]>; 抄送人: trevor.cooper<mailto:[email protected]>;periyasamy.palanisamy<mailto:[email protected]>;zhaoqihui<mailto:[email protected]>;mbuil<mailto:[email protected]>;zhang.jun3g<mailto:[email protected]>;opnfv-tech-discuss<mailto:[email protected]>; 主题: Re: [opnfv-tech-discuss] [edge] meeting minutes for Jul. 25 Hi, On the Requirements Document review (https://gerrit.opnfv.org/gerrit/#/c/58959/): Qihui, if you have any questions to my comments just post them to the review or send them to here. I’m happy to discuss 😉 Also if you are too busy I can try to fix my comments if that is okay with you. Br, Gerg0 From: [email protected]<mailto:[email protected]> [mailto:[email protected]] Sent: Thursday, July 26, 2018 3:47 AM To: rsblendido <[email protected]<mailto:[email protected]>>; georg.kunz <[email protected]<mailto:[email protected]>>; tim.irnich <[email protected]<mailto:[email protected]>>; ildiko <[email protected]<mailto:[email protected]>>; Csatari, Gergely (Nokia - HU/Budapest) <[email protected]<mailto:[email protected]>> Cc: trevor.cooper <[email protected]<mailto:[email protected]>>; periyasamy.palanisamy <[email protected]<mailto:[email protected]>>; zhaoqihui <[email protected]<mailto:[email protected]>>; mbuil <[email protected]<mailto:[email protected]>>; zhang.jun3g <[email protected]<mailto:[email protected]>>; opnfv-tech-discuss <[email protected]<mailto:[email protected]>> Subject: [edge] meeting minutes for Jul. 25 Hi, all. Below are the minutes for yesterday's call. We had a quite efficient discussion about the keystone demo on ONS. Below are the details. We have a few people commit for the keystone demo work. I would like to call to the team and see if anyone else is interested to get involved and help? Please sign up by reply to this email if you could help and indicate which sub group you would like to get involved with. Thank you! 1, Keystone federation demo on ONS Gergely gave an introduction on the current progress of this discussion. It was decided that we will organize two sub group to work on the demo 1. XCI deployment of the whole scenario. we will choose one pharos lab, with two separate bare metal machines to deploy the scenario simulate realizable connection between the two machines assignees: XCI: Rossella, Manuel, Peri（？） 1. test scenario definition and test case development 1. Gergely will help provide a basic story about keystone testing on the following page, and we will continue the discussion on next week's EC WG call 2. https://etherpad.openstack.org/p/ECG_Keystone_Testing assignees: Gergely, Georg 2, Patch review We went through the two commits now in edge repo. Gergely suggested we get the first one updated and merged, and then follow with the second one. AP: could Qihui please update the commit of 58959 according to the comments before the end of this week? we will invite the team to review it during next week and see if we can get it merged before our next call. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#21668): https://lists.opnfv.org/g/opnfv-tech-discuss/message/21668 Mute This Topic: https://lists.opnfv.org/mt/24001591/21656 Group Owner: [email protected] Unsubscribe: https://lists.opnfv.org/g/opnfv-tech-discuss/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
