Hi folks,
the official documentation about "Pooling and XA support for
DataSourceFactory
<https://ops4j1.jira.com/wiki/display/PAXJDBC/Pooling+and+XA+support+for+DataSourceFactory>"
is a bit misleading! It says,
*In addition you can also set pooling properties that start with "pool.".
> These will be forwarded to the pooling library.*
In fact, the properties are not forwarded because the class
org.ops4j.pax.jdbc.config.impl.DataSourceRegistration will have removed
those:
public class DataSourceRegistration implements Closeable {
static final String DATASOURCE_TYPE = "dataSourceType";
static final String JNDI_SERVICE_NAME = "osgi.jndi.service.name";
// By default all local keys (without a dot) are forwarded to the
DataSourceFactory.
// These config keys will explicitly not be forwarded to the
DataSourceFactory
// (even though they are "local" keys without a dot ".")
private static final Set<String> NOT_FORWARDED_KEYS = new HashSet<String
>(Arrays.asList(new String []{
DataSourceFactory.JDBC_DATASOURCE_NAME,
DATASOURCE_TYPE
}));
// additionally all keys prefixed with "jdbc." will be forwarded (with
the prefix stripped).
private static final String CONFIG_KEY_PREFIX = "jdbc.";
...
}
But as you can see in the code above, all properties prepended with "jdbc."
will be forwarded to the DataSourceFactory and the "jdbc." part will be
stripped.
So, the documentation should point out that all properties meant to be
forwarded to DBCP2 should have the prefix "jdbc.pool.", not "pool.". That
could save people a lot of time (I wasted 2 days) and make using pax-jbdc
fun again. :-)
Kind regards
Oliver Marienfeld
--
--
------------------
OPS4J - http://www.ops4j.org - [email protected]
---
You received this message because you are subscribed to the Google Groups
"OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
