Yes .. will recut. If any of you find more issues please let me know.

Christian

On 24.01.2017 18:09, 'Achim Nierbeck' via OPS4J wrote:
Hi Christian,

in case of such uncertainties and with the possibilities to fix, yes just do it :)

regards, Achim


2017-01-24 17:28 GMT+01:00 Jean-Baptiste Onofré <[email protected] <mailto:[email protected]>>:

    Hi Christian

    I would re-cut the release yes.

    Up to you.

    Regards
    JB
    On Jan 24, 2017, at 17:05, Christian Schneider
    <[email protected] <mailto:[email protected]>> wrote:

        I found another issue.

        If you configure a DataSource with pooling but no XA like this:
        osgi.jdbc.driver.name <http://osgi.jdbc.driver.name>=H2
        url=jdbc:h2:mem:test
        dataSourceName=person
        pool=dbcp2

        and then add the pooling support as well as transaction support:
        feature:repo-add pax-jdbc 1.0.0
        feature:install transaction pax-jdbc-config pax-jdbc-pool-dbcp2 
pax-jdbc-h2

        Then you get two DataSources. The reason is that the dbcp2 pooling
        creates two PoolingDataSourceFactory services. One with xa=true and one
        without the
        xa attribute. For just pooling we search for (pool=dbcp2) so we get two
        services and install two DataSources.

        What do you think? Should I redo the release? The artifacts are not yet
        pushed.

        Christian

        On 24.01.2017 11:38, Christian Schneider wrote:

            I have staged a release of pax jdbc 1.0.0 on the sonatype
            nexus:
            https://oss.sonatype.org/content/repositories/orgops4j-1249
            <https://oss.sonatype.org/content/repositories/orgops4j-1249>
            It would be great if you could test it and give feedback.
            I will take care of the update in Apache karaf.
            https://issues.apache.org/jira/browse/KARAF-4956
            <https://issues.apache.org/jira/browse/KARAF-4956> As JB
            wants to do a karaf release 4.1.0 soon with pax jdbc 1.0.0
            I will push the pax jdbc bundles to central later today if
            there is no biggger problem reported. Christian



-- -- ------------------ OPS4J - http://www.ops4j.org -
    [email protected] <mailto:[email protected]> --- You
    received this message because you are subscribed to the Google
    Groups "OPS4J" group. To unsubscribe from this group and stop
    receiving emails from it, send an email to
    [email protected]
    <mailto:[email protected]>. For more options,
    visit https://groups.google.com/d/optout
<https://groups.google.com/d/optout>.
--
Apache Member
Apache Karaf <http://karaf.apache.org/> Committer & PMC OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead blog <http://notizblog.nierbeck.de/>
Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
Software Architect / Project Manager / Scrum Master
-- -- ------------------ OPS4J - http://www.ops4j.org - [email protected] --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected] <mailto:[email protected]>. For more options, visit https://groups.google.com/d/optout.

--
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
http://www.talend.com

--
--
------------------
OPS4J - http://www.ops4j.org - [email protected]

--- You received this message because you are subscribed to the Google Groups "OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to