Hi,

I am working on [PAXWEB-630] Interpret and use the tomcat-server.xml. While 
doing so, I came across an interesting problem.

The tomcat-server.xml can configure host entries (and this does make sense, 
since that allows to add additional configurations like valves to the 
host). 

However, after the config file parsing the mergeConfiguration() method of 
EmbeddedTomcat will change the name of the host configured with the 
EmbeddedTomcatInstance to the first listeningAddress in the configuration 
(and will add new hosts to the engine configured at the engine attribute of 
the EmbeddedTomcatInstance). The first host will be set as defaultHost to 
the engine. Does that really make sense? If I understand the jetty coding 
correctly they try to match the listeningAddresses from the configuration 
with those from the configration file (and add the missing ones). Wouldn't 
that make more sense or is there a reason why the mechanism is as it is 
(except that it is easier to implement that way)?

For the connectors the org.osgi.service.http.enabled and 
org.osgi.service.https.enabled properties take precedence over everything 
else (if they are set to false, all http or https connectors are removed). 
Aside from that a connector for org.osgi.service.http.port and 
org.osgi.service.https.port is added if it does not already exist in the 
config file. I would guess that makes sense.

Can you explain how the merge behaviour of the hosts is supposed to be?

Are my assumptions about the connectors correct?

Best regards
Stephan

-- 
-- 
------------------
OPS4J - http://www.ops4j.org - [email protected]

--- 
You received this message because you are subscribed to the Google Groups 
"OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to