Hi Stephan, Regarding your first issue, this is rather strange cause it actually behaves the same. At least the registration is about the same. I'll try to dig around that a bit. Right now just one thing crosses my mind, maybe it's related to the extra hoops we need to jump through to have servlets and filters registered in some "order" right now.
Regarding PAXWEB-628, yes I think you already fixed it with PAXWEB-630. The idea has been to do the same as with Jetty. The only thing missing is that it's actually possible for the jetty container to register handlers (right now not connectors) as Services. [1] regards, Achim [1] - https://github.com/ops4j/org.ops4j.pax.web/blob/master/pax-web-itest/pax-web-itest-container/pax-web-itest-container-jetty/src/test/java/org/ops4j/pax/web/itest/jetty/JettyHandlerServiceIntegrationTest.java#L85-L118 2017-03-15 17:05 GMT+01:00 Marc Schlegel <[email protected]>: > Thanks for your work. > > Regarding your second question: this might be related to the new > Jetty-TestClient which was added last year as a replacement for Apache > HttpComponents. The error could come from two sources > > 1. The abstraction layer in the JettyTestClient [1] has a bug when > building up a POST-request > 2. The actual test is not preparing the form in the way which works > for JSF > > Right now I tend to think it's the latter since I remember porting some > JSF-tests with a working submit (maybe this one slipped). I might find some > time later this week. Feel free to create a Jira issue and assign it to me. > > regards > Marc > > [1] https://github.com/ops4j/org.ops4j.pax.web/blob/master/ > pax-web-itest/pax-web-itest-base/src/main/java/org/ops4j/ > pax/web/itest/base/client/JettyTestClient.java > > Am Mittwoch, 15. März 2017 15:49:07 UTC+1 schrieb Stephan Siano: >> >> Hi, >> >> I have copied and adapted several (40+) integration tests from jetty to >> tomcat. Sorry for the large number of pull requests for that. The tests >> were running fine in a local build but were unstable on the Jenkins server. >> >> I have not gone through all tests that are ignored in detail, but for now >> I have two findings (and questions): >> 1. filters registered via Whiteboard extender seem not to work with >> Tomcat. There is no error message (at least I didn't find any), the filters >> are just not executed. The funny thing is: filters registered in the >> web.xml of a war work just fine. Does anybody have a clue what the >> whiteboard extender does differently with regards to filters than the war >> extender? >> >> 2. There is one WarJSFPrimefacesIntegrationTest. It has three test >> methods, the main one does not have a @Test annotation (and also does not >> work on jetty). I could update the method and got quite far, but the name >> entered in the form is not sent back. If I try the same thing in a Browser >> (filling in the form and pressing submit), the whole thing works. Does >> anybody have a clue why these tests fail (in Jetty as well as in Tomcat)? >> Another test in this class fetches the form and makes sure that no >> panelGrid-Tag is in the input? This test fails on Tomcat, but I don't get >> why this is wrong. The browser shows the form and I can enter data there. >> However Jetty sends a different HTML for the form. Does anybody know how >> this is achieved? >> >> In addition I had a look into the JIRA for open Tomcat issues: >> >> PAXWEB-513 seems already to be fixed (or I am getting the issue wrong) I >> can add multiple servlet mappings for the same servlet in web.xml with >> tomcat and they work just fine. >> >> What does PAXWEB-628 mean? That Connector and Host entities can be >> configured via tomcat-server.xml? That would be part of PAXWEB-630. >> >> Best regards >> Stephan >> > -- > -- > ------------------ > OPS4J - http://www.ops4j.org - [email protected] > > --- > You received this message because you are subscribed to the Google Groups > "OPS4J" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Apache Member Apache Karaf <http://karaf.apache.org/> Committer & PMC OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & Project Lead blog <http://notizblog.nierbeck.de/> Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> Software Architect / Project Manager / Scrum Master -- -- ------------------ OPS4J - http://www.ops4j.org - [email protected] --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
