created pull request https://github.com/ops4j/org.ops4j.pax.jdbc/pull/36 waiting for merge.
Regards, -Yogesh On Friday, April 7, 2017 at 11:11:53 PM UTC+5:30, Yogesh Rao wrote: > > cool... i will fix it > > Regards, > -Yogesh > > On Friday, April 7, 2017 at 11:00:12 PM UTC+5:30, Christian Schneider > wrote: >> >> I agree .. makes sense to b able to also set xa=false. >> >> Christian >> >> 2017-04-07 19:15 GMT+02:00 Yogesh Rao <[email protected]>: >> >>> Hi, >>> >>> We are using PAX-JDBC 1.0.1 with Karaf 4.0.8, I noticed that pax-jdbc >>> does not work with xa=false set in the datasource config file. xa=false >>> ends up throwing a exception >>> >>> 2017-03-30 20:24:02,902 | ERROR | bc-86c31b8718c3) | configadmin | 7 - >>> org.apache.felix.configadmin - 1.8.12 | >>> [org.osgi.service.cm.ManagedServiceFactory, >>> id=239, bundle=153/mvn:org.ops4j.pax.jdbc/pax-jdbc-config/1.0.1]: Updating >>> configuration org.ops4j.datasource.557b49aa-4050-442d-85bc-86c31b8718c3 >>> caused a problem: XA can only be set to true >>> org.osgi.service.cm.ConfigurationException: null : XA can only be set >>> to true >>> at >>> org.ops4j.pax.jdbc.config.impl.DataSourceConfigManager.isXa(DataSourceConfigManager.java:126)[153:org.ops4j.pax.jdbc.config:1.0.1] >>> at >>> >>> This seems to be a little odd on configuration side to only set xa=true >>> if needed otherwise not have it as part of configuration at all... I would >>> suggest to support xa=false as well unless there is some issue which creeps >>> up (with xa=false) which i am not aware of ... >>> >>> I have the fix ready, let me know if i can create a JIRA and send a pull >>> request. >>> >>> Regards, >>> -Yogesh >>> >>> -- >>> -- >>> ------------------ >>> OPS4J - http://www.ops4j.org - [email protected] >>> >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "OPS4J" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> -- >> Christian Schneider >> http://www.liquid-reality.de >> <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.liquid-reality.de> >> >> Open Source Architect >> http://www.talend.com >> <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.talend.com> >> > -- -- ------------------ OPS4J - http://www.ops4j.org - [email protected] --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
