Hi Achim, sorry this took so long. The change acutally allows both, configuration via config fragment and configuration via wab, so I would probably need both kinds of tests.
The tests you showed use a jetty ResourceHandler and access the resources from the tests. Resources from Tomcat's context.xml do something similar (access resources outside the war) but they are only accessible from the servlet context (not from the outside), so I will have to modify the test servlet and the test compared to the Jetty test. I am not sure whether this has any side effects on the Jetty and Undertow tests. I have also tried to copy samples/wab-jetty-web to samples/wab-tomcat-context (and do some changes in there). However, this one does not build because the build tries to access wab-tomcat-context in version 6.0.1 as a baseline version (which does of course not exist). Ho can I create a new sample bundle without breaking the build? Best regards Stephan Am Freitag, 2. Juni 2017 11:17:40 UTC+2 schrieb Achim Nierbeck: > > Hi Stephan, > > with Jetty we have also the way of using a fragment for changing a > jetty.xml > > https://github.com/ops4j/org.ops4j.pax.web/tree/master/samples/jetty-config-fragment > > if we're talking about something similar to the jetty-web.xml it's here: > > https://github.com/ops4j/org.ops4j.pax.web/tree/master/samples/wab-jetty-web/src/main/webapp/WEB-INF > > a test for the jetty fragment could the this one: > > https://github.com/ops4j/org.ops4j.pax.web/blob/master/pax-web-itest/pax-web-itest-container/pax-web-itest-container-jetty/src/test/java/org/ops4j/pax/web/itest/jetty/JettyConfigurationIntegrationTest.java > > for the jetty-web.xml it's: > > https://github.com/ops4j/org.ops4j.pax.web/blob/master/pax-web-itest/pax-web-itest-container/pax-web-itest-container-jetty/src/test/java/org/ops4j/pax/web/itest/jetty/WabJettyWebIntegrationTest.java > > hope this helps :) > > regards, Achim > > > 2017-06-02 9:17 GMT+02:00 Stephan Siano <[email protected] <javascript:>>: > >> Hi, >> >> I have assigned PAXWEB-629 (configure tomcat via config.xml) to me. I >> have a working implementation that can use META-INF/config.xml from a war >> or config.xml from the config dir or a config fragment (for default context >> configuration). >> >> I could test this manually with a RemoteAddrValve in the context that >> denys access from the public ip address of my system but does allow access >> from localhost. >> >> Does anybody have an idea how this could be tested in an automated >> integration test? >> >> Best regards >> Stephan >> >> -- >> -- >> ------------------ >> OPS4J - http://www.ops4j.org - [email protected] <javascript:> >> >> --- >> You received this message because you are subscribed to the Google Groups >> "OPS4J" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > > Apache Member > Apache Karaf <http://karaf.apache.org/> Committer & PMC > OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & > Project Lead > blog <http://notizblog.nierbeck.de/> > Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> > > Software Architect / Project Manager / Scrum Master > > -- -- ------------------ OPS4J - http://www.ops4j.org - [email protected] --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
