Hi Martin

It makes sense IMHO. Can you please create a Jira about that, I will
improve the versioning management.

Thanks,
Regards
JB

On 10/12/2018 13:04, Martin Lichtin wrote:
> I'd like to to use Pax-Exam with a custom-built Karaf that uses a
> custom versioning.
> Problem is with this code here in KarafManipulatorFactory
>
>         if (dots < 3) {
>             version = new Version(karafVersion.replaceFirst("-", "."));
>         }
>
> It fails if one provides a version such as "1.4-SNAPSHOT". It should
> not do this "replaceFirst".
>
> Also, is it possible to get rid of this code here?
>
>         if (version.getMajor() < 2 || version.getMajor() == 2 &&
> version.getMinor() < 2) {
>             throw new IllegalArgumentException("Karaf versions < 2.2.0
> are not supported");
>         }
>
>
> -- 
> -- 
> ------------------
> OPS4J - http://www.ops4j.org - [email protected]
>
> ---
> You received this message because you are subscribed to the Google
> Groups "OPS4J" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to [email protected]
> <mailto:[email protected]>.
> For more options, visit https://groups.google.com/d/optout.

-- 
-- 
------------------
OPS4J - http://www.ops4j.org - [email protected]

--- 
You received this message because you are subscribed to the Google Groups 
"OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Attachment: pEpkey.asc
Description: application/pgp-keys

Reply via email to