Hello Grzegorz,

I will do that, but how do I get access to JIRA? I tried to log in and got 
"<email> doesn't have access to ops4j1.jira.com*"*

Regards,
Matt

On Friday, March 22, 2019 at 10:12:06 AM UTC-4, Grzegorz Grzybek wrote:
>
> Hello
>
> I was trying to properly partition "pool." and "factory." prefixed 
> properties, but I didn't find problems with hikari - probably I missed 
> something. Could you please create a JIRA for PAXJDBC?
>
> regards
> Grzegorz Grzybek
>
> pt., 22 mar 2019 o 15:01 Matt Bellinger <[email protected] 
> <javascript:>> napisaƂ(a):
>
>> I was using pax-jdbc with HikariCP to connect to PostgreSQL for a project 
>> at work, and we noticed that no matter what settings we used for HikariCP, 
>> they never took effect. It was always a static 10 connections, JMX 
>> monitoring would not be installed, etc.
>>
>> Through some debugging in my IDE I came to realize that the way the 
>> configuration is filtered to the pool, it strips out the 'hikaricp.' 
>> settings before they get to the HikariCP library.
>>
>> DataSourceRegistration::toProperties goes through the properties and 
>> checks if they should be forwarded to the data source factory.  It will 
>> only forward settings with 'pool.' or 'factory.', so the 'hikaricp.' 
>> settings get stripped out.  Unfortunately, if I put 'pool.' in front of my 
>> hikaricp settings, Hikari does not see them, because 
>> HikariPooledDataSourceFactory::getPoolProps only looks for settings 
>> starting with 'hikari.'.
>>
>> To get around it for now, I just hacked in another check for 
>> 'pool.hikari.' in HikariPooledDataSourceFactory::getPoolProps and published 
>> to our local repo, but that does not feel like a proper solution.  I 
>> thought I would post here to see if someone had a more permanent 
>> suggestion, or to see if I was just missing something in the configuration.
>>
>> Best regards,
>> Matt
>>
>> -- 
>> -- 
>> ------------------
>> OPS4J - http://www.ops4j.org - [email protected] <javascript:>
>>
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "OPS4J" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to [email protected] <javascript:>.
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
-- 
------------------
OPS4J - http://www.ops4j.org - [email protected]

--- 
You received this message because you are subscribed to the Google Groups 
"OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to