Hi, it sounds good to me. For the dependencies, don't forget to update the OSGi headers in pax-logging-service.
Regards JB On 18/04/2019 07:54, Grzegorz Grzybek wrote: > Hello > > I have few issues backlogged for PAXLOGGING Jira: > – PAXLOGGING-243: Incorrect bundle names in the logs in case of the > logs come from embeded lib > – PAXLOGGING-247: pax-logging-api/Slf4jMDCAdapter uses stale MDC > after refreshing service bundle > – PAXLOGGING-249: JUL loggers are not properly configured if used > before calling PaxLoggingServiceImpl#setJULLevel > – PAXLOGGING-250: Log4j2 - JNDI based JDBC appender should be more lazy > > So I started to review the code (licenses, deps, upgrading from old > org.ops4j:master:3.3.0, ...). > > I see some code could be refreshed and improved. Here are my concerns > which I'll try to handle if I won't get any feedback): > – should we switch compiler settings to Java8? Not necessary > – I want to upgrade log4j2, slf4j, logback and jboss logging deps > – I want to get rid of those source files from external libs which > can be simply private packaged > – I want to switch org.ops4j.pax.logging.OSGIPaxLoggingManager usage > to singleton - now, each logging facade uses own copy of this manager, > which is effectively a tracker for given PaxLoggingService. > > What do you think? > > regards > Grzegorz Grzybek > -- > -- > ------------------ > OPS4J - http://www.ops4j.org - ops4j@googlegroups.com > > --- > You received this message because you are subscribed to the Google > Groups "OPS4J" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to ops4j+unsubscr...@googlegroups.com > <mailto:ops4j+unsubscr...@googlegroups.com>. > For more options, visit https://groups.google.com/d/optout. -- -- ------------------ OPS4J - http://www.ops4j.org - ops4j@googlegroups.com --- You received this message because you are subscribed to the Google Groups "OPS4J" group. To unsubscribe from this group and stop receiving emails from it, send an email to ops4j+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
