I mean that it's a similar pattern we use for other "connector".

By the way, did you take a look on the websocket example in Karaf ?

Regards
JB

On 25/06/2019 16:22, Stephan Siano wrote:
> Hi,
>
> I'm not so sure whether this is easy. I couldn't find anything about
> the web socket annotations in the War extender (plus the annotation
> scanner in the War extender creates some kind of dummy web.xml
> structure from the scanned annotations, but there are no web.xml
> entries for websockets). 
>
> Nevertheless, are you interested in my changes to the tests? I think
> with these changes the tests start again (at least on Tomcat and
> Undertow), but the tests fail. I also tried to register the Websocket
> programatically with a ContextListener but there I couldn't get the
> ServerContainer from the ServletContext (AFAIK this should work
> via servletContext.getAttribute("javax.websocket.server.ServerContainer");).
> There is probably all the websocket infrastructure missing in the
> Pax-Web classes.
>
> Best regards
> Stephan
>
> On Tuesday, June 25, 2019 at 3:40:22 PM UTC+2, Jean-Baptiste Onofré
> wrote:
>
>     Hi,
>
>     AFAIR, it's not yet fully supported.
>
>     But easy to add/fix, I will tackle that.
>
>     Regards
>     JB
>
>     On 25/06/2019 15:25, Stephan Siano wrote:
>>     Hi,
>>
>>     I have a question concerning web sockets in Pax-Web:
>>
>>     A colleague of mine is trying to deploy a war on a Pax-Web
>>     container that contains some annotated websocket server
>>     endpoints. This works with other web containers but not on Pax
>>     web (he is getting a 404 response when he is trying to upgrade
>>     the connection).
>>
>>     I looked into the Pax-Web integration tests and it turned out
>>     that there is an integration test for a very similar scenario
>>     WebSocketIntegrationTest,testWebSocket() which uses
>>     the websocket-jsr356 sample bundle.
>>
>>     However, this test was disabled. Even worse, it did not work
>>     anymore after the test client was moved from the jetty http
>>     client to the apache http client (because it currently uses a
>>     jetty websocket client which relies on the jetty http client).
>>
>>     I changed the test infrastructure to use a jsr356 client (with
>>     the container specific implementation) and with some hassle
>>     around the class loading because of the pax-exam infrastructure I
>>     could likely get this running (at least with tomcat and
>>     undertow). However on both containers I get a 404 response code
>>     when upgrading the connection (as my colleague got with his
>>     websocket endpoint.
>>
>>     Did this ever work in Pax-Web? I couldn't find any coding that is
>>     parsing for the ServerEndpoint annotation (only Servlet and other
>>     stuff). Or is this still unimplemented?
>>
>>     Best regards
>>     Stephan
>>     -- 
>>     -- 
>>     ------------------
>>     OPS4J - http://www.ops4j.org - op...@googlegroups.com <javascript:>
>>
>>     ---
>>     You received this message because you are subscribed to the
>>     Google Groups "OPS4J" group.
>>     To unsubscribe from this group and stop receiving emails from it,
>>     send an email to op...@googlegroups.com <javascript:>.
>>     To view this discussion on the web visit
>>     
>> https://groups.google.com/d/msgid/ops4j/1baaf72c-d85f-423f-a9f3-91974ca72ba4%40googlegroups.com
>>     
>> <https://groups.google.com/d/msgid/ops4j/1baaf72c-d85f-423f-a9f3-91974ca72ba4%40googlegroups.com?utm_medium=email&utm_source=footer>.
>>     For more options, visit https://groups.google.com/d/optout
>>     <https://groups.google.com/d/optout>.
>
> -- 
> -- 
> ------------------
> OPS4J - http://www.ops4j.org - ops4j@googlegroups.com
>
> ---
> You received this message because you are subscribed to the Google
> Groups "OPS4J" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to ops4j+unsubscr...@googlegroups.com
> <mailto:ops4j+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/ops4j/919b3351-ea5e-46e7-8e3c-310970cb71b1%40googlegroups.com
> <https://groups.google.com/d/msgid/ops4j/919b3351-ea5e-46e7-8e3c-310970cb71b1%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.

-- 
-- 
------------------
OPS4J - http://www.ops4j.org - ops4j@googlegroups.com

--- 
You received this message because you are subscribed to the Google Groups 
"OPS4J" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ops4j+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ops4j/0d56e6d8-2bad-fec5-f7e5-ccf6ba007882%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to