Hi Dhruv, (Focusing the L3NM part)
We made changes to address almost all your suggestions. No changes are made for two of your comments for reasons that we detailed in https://github.com/IETF-OPSAWG-WG/lxnm/issues/263. Can you please check and let us know if that is OK with you. Thank you. Cheers, Med > -----Message d'origine----- > De : OPSAWG [mailto:[email protected]] De la part de Dhruv > Dhody > Envoyé : lundi 5 avril 2021 20:17 > À : Joe Clarke (jclarke) <[email protected]> > Cc : [email protected] > Objet : Re: [OPSAWG] WG LC: L3NM and vpn-common documents > > Hi WG, > > I support publication for both the I-Ds. Some minor comments - > > == > draft-ietf-opsawg-l3sm-l3nm: > - For leaf vpn-type, should we check that it is set to L3VPN in the > YANG? > - For identity provider-dhcp-slaac, should we add if-feature vpn- > common:ipv6. > - typedef area-address is not used, yang:dotted-quad is used for isis > which i think is incorrect. I suggest to use isis:area-address for > ISIS and ospf:area-id-type for OSPF for the respective YANG modules. > - Why is the vpn-node-id a union for string or uint32? This is not > done for any other identifier, only vpn-node-id... > - leaf key for BGP > (/l3vpn-ntw/vpn-services/vpn-service/vpn-nodes/vpn-node/vpn-network- > accesses/vpn-network-accesse/routing-protocols/routing- > protocol/bgp/security/keying-material/key) > has an incorrect description as - "OSPF authentication key." > - Maybe the keying-material should be under NACM? > - s/nontrollers/controllers/g > == _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _______________________________________________ OPSAWG mailing list [email protected] https://www.ietf.org/mailman/listinfo/opsawg
