Hi Joe, Thank you for the comments.
Please see inline. Cheers, Med De : Joe Clarke (jclarke) [mailto:[email protected]] Envoyé : mercredi 19 mai 2021 16:09 À : BOUCADAIR Mohamed TGI/OLN <[email protected]>; [email protected] Cc : [email protected] Objet : Re: New Version Notification for draft-ietf-opsawg-vpn-common-08.txt Thanks, med (and Tom for the review). A few comments on the diff. For your ipv4 and ipv6 feature additions, What about saying: "IPvX traffic can be _carried_ in the VPN..." (or transported, perhaps) [Med] Sure. Fixed. The text "can be assigned to an access" reads odd to me. With respect to the rest of the document, maybe network access is more consistent. [Med] changed to "VPN network access" for better clarity. For the input-bw and output-bw, the use of the words upload and download read odd to me. [Med] For me as well, but this is inherited from RFC8299 and RFC8466. I prefer to maintain those to ease mapping when RFC8299bis and RFC8466bis are considered. What about "upstream" and "downstream" instead? Finally, you removed ccm-priority-type. You had borrowed this, but I wonder if removing this from common causes some other ripples in L2NM. [Med] This was moved back to the L2NM as we use it there. Ultimately, I don't have a problem with this typedef being pulled from its canonical source as long as the downstream ramifications are addressed. Joe [Med] The changes can be tracked: https://github.com/IETF-OPSAWG-WG/lxnm/commit/ab10294cdb24cb147ee0789f76b26395457639a8. On 5/19/21 09:56, [email protected]<mailto:[email protected]> wrote: Hi all, This version addresses the recent comments from Tom (add some reference, update some descriptions). Cheers, Med -----Message d'origine----- De : [email protected]<mailto:[email protected]> [mailto:[email protected]] Envoyé : mercredi 19 mai 2021 15:50 À : BOUCADAIR Mohamed TGI/OLN <[email protected]><mailto:[email protected]>; Oscar Gonzalez de Dios <[email protected]><mailto:[email protected]>; Oscar de Dios <[email protected]><mailto:[email protected]>; Qin WU <[email protected]><mailto:[email protected]>; Qin Wu <[email protected]><mailto:[email protected]>; Samier Barguil <[email protected]><mailto:[email protected]>; samier barguil <[email protected]><mailto:[email protected]> Objet : New Version Notification for draft-ietf-opsawg-vpn-common- 08.txt A new version of I-D, draft-ietf-opsawg-vpn-common-08.txt has been successfully submitted by Mohamed Boucadair and posted to the IETF repository. Name: draft-ietf-opsawg-vpn-common Revision: 08 Title: A Layer 2/3 VPN Common YANG Model Document date: 2021-05-19 Group: opsawg Pages: 68 URL: https://www.ietf.org/archive/id/draft-ietf-opsawg- vpn-common-08.txt Status: https://datatracker.ietf.org/doc/draft-ietf-opsawg- vpn-common/ Htmlized: https://datatracker.ietf.org/doc/html/draft-ietf- opsawg-vpn-common Htmlized: https://tools.ietf.org/html/draft-ietf-opsawg-vpn- common-08 Diff: https://www.ietf.org/rfcdiff?url2=draft-ietf-opsawg- vpn-common-08 Abstract: This document defines a common YANG module that is meant to be reused by various VPN-related modules such as Layer 3 VPN and Layer 2 VPN network models. Editorial Note (To be removed by RFC Editor) Please update these statements within the document with the RFC number to be assigned to this document: o "This version of this YANG module is part of RFC XXXX;" o "RFC XXXX: A Layer 2/3 VPN Common YANG Model"; o reference: RFC XXXX Also, please update the "revision" date of the YANG module. Please note that it may take a couple of minutes from the time of submission until the htmlized version and diff are available at tools.ietf.org. The IETF Secretariat _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
_______________________________________________ OPSAWG mailing list [email protected] https://www.ietf.org/mailman/listinfo/opsawg
