Reviewer: Ladislav Lhotka Review result: Ready with Nits **** General comments
The Internet-Draft contains a large YANG module that augments the network topology model with L2/L3 VPN performance monitoring statistics. The module is well designed and documented, I found no issues in it. Examples of JSON instance data are useful for readers of the I-D, but less so if they contain errors (see below). If possible, I'd suggest to validate the examples with appropriate tools, or at least carefully check after each change in the data model. **** Specific comments ***** Section 5 - File name in <CODE BEGINS> line should be ...@2022-04-08.yang ***** Appendix A.2 - module "ietf-network-topo" doesn't exist, should it be "ietf-network"? ***** Appendix A.3 - leaf "middle-percentile" should probably be "intermediate-percentile". - leaf "unit-values" should be "unit-value" - The leaf "ietf-network-vpn-pm:inter-vpn-access-interface" is illegal (probably misplaced) _______________________________________________ OPSAWG mailing list OPSAWG@ietf.org https://www.ietf.org/mailman/listinfo/opsawg
