Hi Martin, all, FWIW, the proposed changes are now implemented in the public version: https://datatracker.ietf.org/doc/html/draft-ietf-opsawg-ac-lxsm-lxnm-glue-06.
Cheers, Med > -----Message d'origine----- > De : BOUCADAIR Mohamed INNOV/NET > Envoyé : jeudi 25 janvier 2024 13:56 > À : 'Martin Björklund' <mbj+i...@4668.se> > Cc : yang-doct...@ietf.org; draft-ietf-opsawg-ac-lxsm-lxnm- > glue....@ietf.org; opsawg@ietf.org > Objet : RE: Yangdoctors early review of draft-ietf-opsawg-ac-lxsm- > lxnm-glue-04 > > Hi Martin, > > Thank you for the follow-up. > > Fixed the nits in the yang file. Also updated the module to make use > of the new groupings for referencing purposes instead of the broken > typedefs in the ac-ntw: > > https://author-tools.ietf.org/api/iddiff?iddiff?doc_1=draft-ietf- > opsawg-ac-lxsm-lxnm-glue&url_2=https://boucadair.github.io/attachment- > circuit-model/boucadair-patch-5/draft-ietf-opsawg-ac-lxsm-lxnm- > glue.txt > > Cheers, > Med > > > -----Message d'origine----- > > De : Martin Björklund <mbj+i...@4668.se> Envoyé : mercredi 24 > janvier > > 2024 16:52 À : BOUCADAIR Mohamed INNOV/NET > > <mohamed.boucad...@orange.com> Cc : yang-doct...@ietf.org; > > draft-ietf-opsawg-ac-lxsm-lxnm- glue....@ietf.org; opsawg@ietf.org > > Objet : Re: Yangdoctors early review of draft-ietf-opsawg-ac-lxsm- > > lxnm-glue-04 > > > > mohamed.boucad...@orange.com wrote: > > > Hi Martin, > > > > > > Thanks for the review. > > > > > > FWIW, a new version that fixes the nit you reported and other > minor > > pending we had is available online: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fauth > > > or-tools.ietf.org%2Fiddiff%3Furl2%3Ddraft-ietf-opsawg-ac-lxsm- > lxnm- > > glu > > > e- > > 05&data=05%7C02%7Cmohamed.boucadair%40orange.com%7C46a62fe529bd44020 > > > > > > 91308dc1cf473e7%7C90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C638417083 > > > > > > 964251050%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > > > > > > LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C41000%7C%7C%7C&sdata=ZWGtBagO6Z2BiYEH > > > xG8yqYJwwzj72LPLDoUVEKRHM2U%3D&reserved=0 > > > > That was quick! However, the spelling error is still there, and I > > think you introduced a new one ;-) > > > > > > was provisionned using the ACaaS module."; > > ^^^^^^^^^^^^ > > > > Thansk to Martin Björklund for the yangdoctors review. > > ^^^^^^ > > > > > > > > /martin > > > > > > > > > > > > > > > > > > Cheers, > > > Med > > > > > > > -----Message d'origine----- > > > > De : Martin Björklund via Datatracker <nore...@ietf.org> > Envoyé : > > > > mercredi 24 janvier 2024 16:18 À : yang-doct...@ietf.org Cc : > > > > draft-ietf-opsawg-ac-lxsm-lxnm-glue....@ietf.org; > opsawg@ietf.org > > > > Objet : Yangdoctors early review of draft-ietf-opsawg-ac-lxsm- > > lxnm- > > > > glue-04 > > > > > > > > Reviewer: Martin Björklund > > > > Review result: Ready with Nits > > > > > > > > This is a very short, and from a YANG-perspective simple, > module. > > It > > > > looks good, and I also found one nit: > s/provisionned/provisioned/g > > > > > > > > /martin > > > > > > > > > > > > > ______________________________________________________________________ > > > ______________________________________ > > > Ce message et ses pieces jointes peuvent contenir des informations > > > confidentielles ou privilegiees et ne doivent donc pas etre > > diffuses, > > > exploites ou copies sans autorisation. Si vous avez recu ce > message > > > par erreur, veuillez le signaler a l'expediteur et le detruire > ainsi > > que les pieces jointes. Les messages electroniques etant > susceptibles > > d'alteration, Orange decline toute responsabilite si ce message a > ete > > altere, deforme ou falsifie. Merci. > > > > > > This message and its attachments may contain confidential or > > > privileged information that may be protected by law; they should > not > > be distributed, used or copied without authorisation. > > > If you have received this email in error, please notify the sender > > and delete this message and its attachments. > > > As emails may be altered, Orange is not liable for messages that > > have been modified, changed or falsified. > > > Thank you. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _______________________________________________ OPSAWG mailing list OPSAWG@ietf.org https://www.ietf.org/mailman/listinfo/opsawg
