Hi Joe, Works for me [1]. Will queue the change for the next iteration.
Thank you. Cheers, Med [1] https://github.com/boucadair/udp-ipfix/commit/5d7394f847d45619bd95527f44827fdc5537560c De : to...@strayalpha.com <to...@strayalpha.com> Envoyé : vendredi 24 mai 2024 01:43 À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucad...@orange.com> Cc : Aitken, Paul <pait...@ciena.com>; drafts-expert-review-comm...@iana.org; ie-doct...@ietf.org; opsawg@ietf.org Objet : Re: [IANA #1363824] Expert review for draft-ietf-opsawg-tsvwg-udp-ipfix (ipfix) Suggest removing “first” below; Removing "the 64 most significant bits" is sufficient. — Dr. Joe Touch, temporal epistemologist www.strayalpha.com<http://www.strayalpha.com> On May 23, 2024, at 10:51 AM, mohamed.boucad...@orange.com<mailto:mohamed.boucad...@orange.com> wrote: Re-, Thanks. Please see one comment inline. Cheers, Med De : Aitken, Paul <pait...@ciena.com<mailto:pait...@ciena.com>> Envoyé : jeudi 23 mai 2024 18:31 À : BOUCADAIR Mohamed INNOV/NET <mohamed.boucad...@orange.com<mailto:mohamed.boucad...@orange.com>>; drafts-expert-review-comm...@iana.org<mailto:drafts-expert-review-comm...@iana.org>; Joe Touch <to...@strayalpha.com<mailto:to...@strayalpha.com>> Cc : ie-doct...@ietf.org<mailto:ie-doct...@ietf.org>; opsawg@ietf.org<mailto:opsawg@ietf.org> Objet : Re: [IANA #1363824] Expert review for draft-ietf-opsawg-tsvwg-udp-ipfix (ipfix) Sigh. In sections 7.1 and 7.2, s/192/256/ Add this line and change the ADT: 4.1. udpSafeOptions Name: udpSafeOptions ElementID: TBD1 Description: Observed safe UDP options in a Flow. The information is encoded in a set of bit fields. Options are mapped to bits according to their option numbers. UDP option Kind 0 corresponds to the least-significant bit in the udpSafeOptions IE while Kind 191 corresponds to the most- significant bit of the IE. [Med] I guess this one should be updated as well. No? The bit is set to 1 if the corresponding safe UDP option is observed in the Flow. The bit is set to 0 if the option is not observed in the Flow. + The first 64 most-significant bits MUST be set to 0. The reduced-size encoding per Section 6.2 of [RFC7011] is followed whenever fewer octets are needed to report observed safe UDP options. For example, if only option Kinds <= 31 are observed, then the value of the udpSafeOptions IE can be encoded as unsigned32, or if only option Kinds <= 63 are observed, then the value of the udpSafeOptions IE can be encoded as unsigned64. ... Abstract Data Type: unsigned256 P. On 23/05/24 16:46, mohamed.boucad...@orange.com<mailto:mohamed.boucad...@orange.com> wrote: Re-, Please share the OLD/NEW text that you would like to see and will implement it. Thanks. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
_______________________________________________ OPSAWG mailing list -- opsawg@ietf.org To unsubscribe send an email to opsawg-le...@ietf.org
