Hi Jensen, Thanks for the comments. A PR to address your comments can be seen at: https://github.com/IETF-OPSAWG-WG/policy-based-network-acl/pull/115/files.
Cheers, Med (as author) De : Jensen Zhang <[email protected]> Envoyé : mardi 7 octobre 2025 04:03 À : Joe Clarke (jclarke) <[email protected]> Cc : opsawg <[email protected]> Objet : [OPSAWG]Re: WG LC: A YANG Data Model and RADIUS Extension for Policy-based Network Access Control (draft-ietf-opsawg-ucl-acl) Hi WG, Charis, I have reviewed this draft. The document is well written. Just see below about some minor issues and comments: --- COMMENTS --- Section 5.1., paragraph 7: > "group-id" is defined as a string rather than unsigned integer I'm fine if the "group-id" is not limited to a give set of valid characters or patterns. But there is even no limit about the length of a "group-id"? [Med] There is this limit in YANG module itself. leaf group-id { type string { length "1..64"; } --- Typos and Nits --- Appendix A., paragraph 36: > </byday> > <byday> > <weekday>friday</weekday> > </byday> > <recurrence> typo? <recurrence> -> </recurrence> [Med] Agree. Fixed. Appendix A., paragraph 37: > </effective-schedule> > </ace> > <ace> > <name>rule2</name> > <matches> > <ipv6> > <destination-ipv6-network>2001:db8:1234::/64</\ > destination-ipv6-network> > <source-ipv6-network>2001:db8::2:1/64</source-ipv6-\ > network> > </ipv4> typo? </ipv4> -> </ipv6> [Med] Agree. Fixed. Appendix A., paragraph 38: > </matches> > <actions> > <forwarding>reject</forwarding> > </actions> > <effective-schedule xmlns="urn:ietf:params:xml:ns:yang:ietf-\ > ucl-acl"> > <period> > <period-start>2026-01-20T08:30:00-08:00</period-start> > <period-end>2026-12-31T18:00:00-08:00</period-end> > </period> > </effective-schedule> > </ace> > </aces> > </aces> nits: should remove the repeated </aces> [Med] Fixed. Best regards, Jensen On Mon, Sep 29, 2025 at 10:25 PM Joe Clarke (jclarke) <[email protected]<mailto:[email protected]>> wrote: Hello, WG. We’re extending the WG LC on this by a week until October 6 to hopefully get a couple of DIR reviews and some more comments from the WG itself. Please, take the time to read this and comment on its readiness. Thanks. Joe and Benoît From: Joe Clarke (jclarke) <[email protected]<mailto:[email protected]>> Date: Monday, September 15, 2025 at 09:14 To: opsawg <[email protected]<mailto:[email protected]>> Subject: WG LC: A YANG Data Model and RADIUS Extension for Policy-based Network Access Control (draft-ietf-opsawg-ucl-acl) Hello, opsawg. With the IPR disclosure done (no known IPR has been disclosed) and a new -08 revision, we are ready to begin a two week WG LC for https://datatracker.ietf.org/doc/draft-ietf-opsawg-ucl-acl/. Please reply to the list with comments and support for this work being ready to move forward to the IESG for publication. The WG LC will run until September 29. Thanks. Joe and Benoît _______________________________________________ OPSAWG mailing list -- [email protected]<mailto:[email protected]> To unsubscribe send an email to [email protected]<mailto:[email protected]> ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
_______________________________________________ OPSAWG mailing list -- [email protected] To unsubscribe send an email to [email protected]
