This is a contributor review of draft-ietf-opsawg-discardmodel-09. Overall, I found the draft in pretty good shape. The authors have done a great job incorporating feedback. I do have a few suggestions, and I found a couple nits.
Wouldn’t invalid-frame and invalid-packet encompass CRC errors and checksum errors? Prior to introducing the YANG data model, you address that frames/packets cannot be double-counted, but I think it would be beneficial to add some mention of that to the IM. Maybe in the description of the invalid-* you explicitly state these count frames/packets other than when a CRC or checksum error has been detected. In the IM, you have a feature for flow-reporting, but you do not include this in the DM. Why? I would imagine this feature might be used by certain vendors’ implementations to reflect per-flow drop statistics. And having a common feature defined, even if not immediately used by this module could be useful. Nits: In Section 3, expand “pps”. In Section 3, maybe s/crucial for selecting the appropriate of mitigation/crucial for selecting the appropriate type of mitigation/ Joe
_______________________________________________ OPSAWG mailing list -- [email protected] To unsubscribe send an email to [email protected]
