Title: [opsview] [9996] Fixed bug where later schema steps were missed when a mixture of
- Revision
- 9996
- Author
- tvoon
- Date
- 2012-09-07 10:49:13 +0100 (Fri, 07 Sep 2012)
Log Message
Fixed bug where later schema steps were missed when a mixture of
old and new style existed
Modified Paths
Modified: trunk/opsview-core/lib/Utils/DBVersion.pm
===================================================================
--- trunk/opsview-core/lib/Utils/DBVersion.pm 2012-09-07 00:03:50 UTC (rev 9995)
+++ trunk/opsview-core/lib/Utils/DBVersion.pm 2012-09-07 09:49:13 UTC (rev 9996)
@@ -132,6 +132,11 @@
"SELECT major_release FROM " . $self->schema_table() . ""
);
if (@$releases) {
+
+ # Need to do this to remove all new style major_release numbers
+ # Which caused a problem with the comparisons later
+ $releases = [ grep {/^\d+\.\d+$/} (@$releases) ];
+
my $flag = scalar @$releases;
foreach my $major (@$releases) {
my @a = split( /\./, $major );
Modified: trunk/opsview-core/t/87dbversion.t
===================================================================
--- trunk/opsview-core/t/87dbversion.t 2012-09-07 00:03:50 UTC (rev 9995)
+++ trunk/opsview-core/t/87dbversion.t 2012-09-07 09:49:13 UTC (rev 9996)
@@ -205,3 +205,9 @@
like( $@, qr/Product not set/, "Product not set" );
eval { $db->is_installed( "20120906text", "Example upgrade", "bad" ) };
like( $@, qr/Bad product: bad/, "Bad product" );
+
+is(
+ $db->is_lower("5.87.1"),
+ 1,
+ "This should be required - had problem where new style numbering caused issues"
+);
_______________________________________________
Opsview-checkins mailing list
[email protected]
http://lists.opsview.org/lists/listinfo/opsview-checkins
