Title: [opsview] [10955] Merge from BRAN-4.2: Rogue plugin does not stop populatedb.pl from finishing
Revision
10955
Author
tvoon
Date
2012-12-05 00:36:57 +0000 (Wed, 05 Dec 2012)

Log Message

Merge from BRAN-4.2: Rogue plugin does not stop populatedb.pl from finishing

Modified Paths

Property Changed


Property changes on: trunk
___________________________________________________________________
Modified: svn:mergeinfo
   - /branches/DEV-capside/release-3.9.0:6365-6370
/branches/DEV-extra-notification-data:6734-6746
/branches/DEV-odw-calculations:9016-9160
/branches/DEV-restapi-monitoringservers:9778
/branches/DEV-snmp-multi:7324-7376
/branches/US187:9403-9479
/branches/US198b:8875-8994
/branches/US310:9851-9873
/branches/enterprise/BRAN-3.14:6874,6882,6956
/branches/enterprise/DEV-professional:6494-8475,8477-8478,8486,8490,8492,8494,8499-8500,8515,8518-8519,8524,8527-8529,8531-8532,8536,8538,8540-8544,8547-8552,8554,8557,8600-8601,8637,8749,8772,8897,8917,8944-8945,8947,8950-8952,8967,8969,8979,8982,8987,8998,9006,9008,9011,9013,9026,9033-9036,9038,9040,9042,9044,9048,9050-9053,9062,9064-9065,9069,9078,9081,9088,9096,9099-9101,9103,9105,9115,9118,9347,9353-9354,9411,9432,9445,9486,9538-9550,9569-9571,9620,9635,9637-9638,9645-9647,9693,9699,9721,9814,9825,9857,9879,9881,9939,10002,10029,10038-10041,10070,10086,10093,10345,10347,10388,10407,10481,10549,10560-10562,10565,10568,10571,10577
/branches/nagvis-iframe:9764-9786
/branches/us168:8759,8762-8763,8766-8768,8770,8774-8777,8794,8798-8799,8801-8803,8821-8822,8834,8837-8838,8932,8937,8947,8969,8977,8981,9004,9007,9009-9010,9012,9024,9049
/commercial/branches/US306-slaves:9804-9823
/commercial/branches/US307-network-map:9685-9837
   + /branches/DEV-capside/release-3.9.0:6365-6370
/branches/DEV-extra-notification-data:6734-6746
/branches/DEV-odw-calculations:9016-9160
/branches/DEV-restapi-monitoringservers:9778
/branches/DEV-snmp-multi:7324-7376
/branches/US187:9403-9479
/branches/US198b:8875-8994
/branches/US310:9851-9873
/branches/enterprise/BRAN-3.14:6874,6882,6956
/branches/enterprise/DEV-professional:6494-8475,8477-8478,8486,8490,8492,8494,8499-8500,8515,8518-8519,8524,8527-8529,8531-8532,8536,8538,8540-8544,8547-8552,8554,8557,8600-8601,8637,8749,8772,8897,8917,8944-8945,8947,8950-8952,8967,8969,8979,8982,8987,8998,9006,9008,9011,9013,9026,9033-9036,9038,9040,9042,9044,9048,9050-9053,9062,9064-9065,9069,9078,9081,9088,9096,9099-9101,9103,9105,9115,9118,9347,9353-9354,9411,9432,9445,9486,9538-9550,9569-9571,9620,9635,9637-9638,9645-9647,9693,9699,9721,9814,9825,9857,9879,9881,9939,10002,10029,10038-10041,10070,10086,10093,10345,10347,10388,10407,10481,10549,10560-10562,10565,10568,10571,10577
/branches/nagvis-iframe:9764-9786
/branches/us168:8759,8762-8763,8766-8768,8770,8774-8777,8794,8798-8799,8801-8803,8821-8822,8834,8837-8838,8932,8937,8947,8969,8977,8981,9004,9007,9009-9010,9012,9024,9049
/commercial/branches/BRAN-4.2:10944
/commercial/branches/US306-slaves:9804-9823
/commercial/branches/US307-network-map:9685-9837

Modified: trunk/CHANGES
===================================================================
--- trunk/CHANGES	2012-12-04 21:33:18 UTC (rev 10954)
+++ trunk/CHANGES	2012-12-05 00:36:57 UTC (rev 10955)
@@ -20,6 +20,8 @@
     Fixed messages for set state
     Fixed display of check_snmp_interfaces_cascade so that bits/s to Gbps is using division by 1000^3 rather than 1024^3
     Fixed rc.opsview-agent init script to pick up when nrpe is running on an incorrectly recorded pid
+    Fixed installation on SLES11 where check_http_authentication would cause upgrades to hang
+    Fixed SOAP::Lite perl module error
 
 3.20120925
     FEATURES:

Modified: trunk/opsview-core/bin/populate_db.pl
===================================================================
--- trunk/opsview-core/bin/populate_db.pl	2012-12-04 21:33:18 UTC (rev 10954)
+++ trunk/opsview-core/bin/populate_db.pl	2012-12-05 00:36:57 UTC (rev 10955)
@@ -44,6 +44,7 @@
 use Data::Dumper;
 use Text::CSV::Simple;
 use Sys::Hostname;
+use Try::Tiny;
 
 my $param = shift @ARGV || "plugins";
 
@@ -70,7 +71,26 @@
             @output = ( "testmode!" );
         }
         else {
-            @output = `$command`;
+            my $timeout = 10;
+            my $rc;
+            try {
+                local $SIG{ALRM} = sub { die "alarm\n" };
+                alarm $timeout;
+                @output = `$command`;
+                alarm 0;
+                $rc = $? >> 8;
+            }
+            catch {
+                @output = ( "Timeout $timeout seconds running $command\n" );
+                if ( $_ ne "alarm\n" ) {
+                    push @output, "Details: $_";
+                }
+            };
+
+            # Cannot do below as it is not defined what the return code from -h is
+            #if ($rc != 0) {
+            #    @output = ("Error gathering help for $command: rc=$rc");
+            #}
         }
         my $obj = Opsview::Plugin->find_or_create(
             { name => $plugin },

_______________________________________________
Opsview-checkins mailing list
[email protected]
http://lists.opsview.org/lists/listinfo/opsview-checkins

Reply via email to