Modified: trunk/opsview-core/nagios-plugins/check_snmp_weblogic_clusterservers
===================================================================
--- trunk/opsview-core/nagios-plugins/check_snmp_weblogic_clusterservers 2013-02-08 10:56:38 UTC (rev 11387)
+++ trunk/opsview-core/nagios-plugins/check_snmp_weblogic_clusterservers 2013-02-08 12:14:32 UTC (rev 11388)
@@ -19,122 +19,82 @@
# along with Opsview; if not, write to the Free Software
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#
-
use strict;
-use lib qw ( /usr/local/nagios/perl/lib );
+use warnings;
+
+use FindBin qw($Bin);
+use lib "/opt/opsview/perl/lib/perl5", "$Bin/../lib";
use Net::SNMP;
-use DBI;
-use Getopt::Std;
+use Opsview::NagiosPlugin::SNMP;
-# About us
-my $script = "check_snmp_weblogic_clusterservers";
-my $script_version = "1.0";
-my $script_description =
- "Checks the number of cluster servers - either active or total";
+my $np = Opsview::NagiosPlugin::SNMP->new(
+ usage => "Usage: %s",
+ shortname => "check_snmp_weblogic_clusterservers",
+ version => "1.1",
+ blurb => "Checks the number of cluster servers - either active or total",
+ snmp => { "snmp-version" => 1, },
+);
-my $hostname;
+$np->add_arg(
+ spec => "warning|w=s",
+ help => qq{-w, --warning=INTEGER
+ Warning threshold (minimum)},
+ required => 1,
+);
-# Performance data
-my $perfdata = "";
+$np->add_arg(
+ spec => "critical|c=s",
+ help => qq{-c, --critical=INTEGER
+ Critical threshold (minimum)},
+ required => 1,
+);
-# SNMP variables
-my $oid_testoid =
- ".1.3.6.1.4.1.140.625.10.1.0"; # Used to check whether SNMP is responding
-my $oid_totalservers =
- ".1.3.6.1.4.1.140.625.110.1.50"; # comma separated, just count them
-my $oid_activeservers =
- ".1.3.6.1.4.1.140.625.110.1.25"; # get_next here to find the value
-my $count = 0; # count of servers/connections
-my $community = "public"; # Default community
-my $timeout = 2; # SNMP timeout
-my $retmsg = "";
-my $version = "1";
-my $warning = 0;
-my $critical = 0;
-my $check_total = 0;
-my $port = 161;
-our ( $s, $e );
+$np->add_arg(
+ spec => "server|s=s",
+ help => qq{-s, --servername=INTEGER
+ Server name},
+);
-# Command line arguments
-our ( $opt_h, $opt_H, $opt_C, $opt_w, $opt_c, $opt_s, $opt_S, $opt_A, $opt_p );
-getopts( "hH:C:w:c:s:SAp:" );
-if ($opt_h) {
- usage();
- exit 0;
-}
-if ($opt_H) {
- $hostname = $opt_H;
-}
-else {
- print "No hostname specified\n";
- usage();
- exit 3;
-}
-if ($opt_C) {
- $community = $opt_C;
-}
-if ( !$opt_w or !$opt_c ) {
- print "Must specify both warning and critical values!\n\n";
- usage();
- exit 3;
-}
-if ($opt_s) {
- $community = "$community\@$opt_s";
-}
-if ( $opt_S and $opt_A ) {
- print "Must specify EITHER -S or -A\n\n";
- usage();
- exit 3;
-}
-if ($opt_S) {
+$np->add_arg(
+ spec => "servers|S=s",
+ help => qq{-S, --servers=INTEGER
+ Servers in cluster},
+);
+
+$np->add_arg(
+ spec => "activeservers|A=s",
+ help => qq{-A, --activeservers=INTEGER
+ Active servers},
+);
+
+$np->getopts;
+
+my $warning = $np->opts->warning;
+my $critical = $np->opts->critical;
+my $check_total;
+
+#check required options being used
+if ( $np->opts->servers ) {
$check_total = 1;
}
-elsif ($opt_A) {
+elsif ( $np->opts->activeservers ) {
$check_total = 0;
}
else {
- print "Must specify one of -S or -A\n\n";
- usage();
+ print "Must specify either -S or -A\n";
exit 3;
}
-if ($opt_p) {
- $port = $opt_p;
-}
-# Must have opt_w and opt_c
-$warning = $opt_w;
-$critical = $opt_c;
+my $s = $np->snmp;
-sub usage {
- print <<EOF
---------------------------------------------------------------------
+my $oid_testoid = ".1.3.6.1.4.1.140.625.10.1.0";
+my $oid_totalservers = ".1.3.6.1.4.1.140.625.110.1.50";
+my $oid_activeservers = ".1.3.6.1.4.1.140.625.110.1.25";
-$script $script_version
+my $count = 0;
+my $retmsg = "";
+my $perfdata = "";
-$script_description
-
-Usage: $script -H <hostname> -C <community> -w <warning> -c <critical>
- -s <server_name> [-S|-A]
-
-Options: -H Hostname or IP address
- -p Port (default: 161)
- -C Community (default is public)
- -w Warning threshold (minimum)
- -c Critical threshold (minimum)
- -s Server name
- -S Servers in cluster
- -A Active servers
-
---------------------------------------------------------------------
-Copyright (C) 2003-2012 Opsview Limited. All rights reserved
-
-This program is free software; you can redistribute it or modify
-it under the terms of the GNU General Public License
-------------------------------------------------------------------
-EOF
-
-}
-
# Call this when you know you'll get a single value back
sub get_oid_value {
our ( $oid, $result, $status, $returnstring );
@@ -165,30 +125,9 @@
return $result;
}
-# Create the SNMP session
-( $s, $e ) = Net::SNMP->session(
- -community => $community,
- -hostname => $hostname,
- -version => $version,
- -timeout => $timeout,
- -port => $port,
-);
-
if ( !defined( $s->get_request($oid_testoid) ) ) {
-
- # If we can't connect using SNMPv1 lets try as SNMPv2c
- $s->close();
- sleep 0.5;
- $version = "2c";
- ( $s, $e ) = Net::SNMP->session(
- -community => $community,
- -hostname => $hostname,
- -version => $version,
- -timeout => $timeout,
- -port => $port,
- );
if ( !defined( $s->get_request($oid_testoid) ) ) {
- print "Agent not responding, tried SNMP v1 and v2\n";
+ print "Agent not responding";
exit 1;
}
}
@@ -197,7 +136,8 @@
if ( $check_total eq 1 ) {
my $serverlist = get_oid_value($oid_totalservers);
- $count = scalar( split( /,/, $serverlist ) );
+ my @count = split( /,/, $serverlist );
+ $count = @count;
if ( $count eq -1 ) {
print "UNKNOWN - Plugin error, couldn't retrieve OID\n";
