Title: [opsview] [11410] Updated check_snmp_weblogic_lockedout to use SNMPv3 library
Revision
11410
Author
hstevenson
Date
2013-02-12 10:14:52 +0000 (Tue, 12 Feb 2013)

Log Message

Updated check_snmp_weblogic_lockedout to use SNMPv3 library

Modified Paths


Modified: trunk/opsview-core/nagios-plugins/check_snmp_weblogic_lockedout
===================================================================
--- trunk/opsview-core/nagios-plugins/check_snmp_weblogic_lockedout	2013-02-12 10:14:28 UTC (rev 11409)
+++ trunk/opsview-core/nagios-plugins/check_snmp_weblogic_lockedout	2013-02-12 10:14:52 UTC (rev 11410)
@@ -20,99 +20,49 @@
 #    along with Opsview; if not, write to the Free Software
 #    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 #
-
 use strict;
-use lib qw ( /usr/local/nagios/perl/lib );
+use warnings;
+
+use FindBin qw($Bin);
+use lib "/opt/opsview/perl/lib/perl5", "$Bin/../lib";
 use Net::SNMP;
-use DBI;
-use Getopt::Std;
+use Opsview::NagiosPlugin::SNMP;
 
-# About us
-my $script             = "check_snmp_weblogic_lockedout";
-my $script_version     = "1.0";
-my $script_description = "Checks the current number of locked out users";
+my $np = Opsview::NagiosPlugin::SNMP->new(
+    usage     => "Usage: %s",
+    shortname => "check_snmp_weblogic_lockedout",
+    version   => "1.1",
+    blurb     => "Checks the current number of locked out users",
+    snmp      => { "snmp-version" => 1, },
+);
 
-my $hostname;
+$np->add_arg(
+    spec => "warning|w=s",
+    help => qq{-w, --warning=INTEGER
+    Warning threshold},
+    required => 1,
+);
 
-# Performance data
-my $perfdata = "";
+$np->add_arg(
+    spec => "critical|c=s",
+    help => qq{-c, --critical=INTEGER
+    Critical threshold},
+    required => 1,
+);
 
-# SNMP variables
-my $oid_testoid =
-  ".1.3.6.1.4.1.140.625.10.1.0"; # Used to check whether SNMP is responding
-my $oid_lockedout =
-  ".1.3.6.1.4.1.140.625.371.1.50"; # get_next here to find the value
-my $num_lockedout = 0;             # Current locked out user count
-my $community     = "public";      # Default community
-my $timeout       = 2;             # SNMP timeout
-my $version       = "1";
-my $warning       = 0;
-my $critical      = 0;
-my $port          = 161;
-our ( $s, $e );
+$np->getopts;
 
-# Command line arguments
-our ( $opt_h, $opt_H, $opt_C, $opt_w, $opt_c, $opt_p );
-getopts( "hH:C:w:c:p:" );
-if ($opt_h) {
-    usage();
-    exit 0;
-}
-if ($opt_H) {
-    $hostname = $opt_H;
-}
-else {
-    print "No hostname specified\n";
-    usage();
-    exit 3;
-}
-if ($opt_C) {
-    $community = $opt_C;
-}
-if ( !$opt_w or !$opt_c ) {
-    print "Must specify both warning and critical values!\n\n";
-    usage();
-    exit 3;
-}
-elsif ( $opt_w > $opt_c ) {
-    print "Warning value must not be greater than critical value\n\n";
-    usage();
-    exit 3;
-}
-if ($opt_p) {
-    $port = $opt_p;
-}
+my $warning  = $np->opts->warning;
+my $critical = $np->opts->critical;
 
-# Must have opt_w and opt_c
-$warning  = $opt_w;
-$critical = $opt_c;
+my $s = $np->snmp;
 
-sub usage {
-    print <<EOF
---------------------------------------------------------------------
+my $oid_testoid   = ".1.3.6.1.4.1.140.625.10.1.0";
+my $oid_lockedout = ".1.3.6.1.4.1.140.625.371.1.50";
 
-$script $script_version
+my $num_lockedout = 0;
+my $perfdata      = "";
 
-$script_description
-
-Usage: $script -H <hostname> -C <community> -w <warning> -c <critical>
-
-Options: -H     Hostname or IP address
-         -p     Port (default: 161)
-         -C     Community (default is public)
-         -w     Warning threshold
-         -c     Critical threshold
-
---------------------------------------------------------------------
-Copyright (C) 2003-2012 Opsview Limited. All rights reserved
-
-This program is free software; you can redistribute it or modify
-it under the terms of the GNU General Public License
-------------------------------------------------------------------
-EOF
-
-}
-
 # Call this when you know you'll get a single value back
 sub get_oid_value {
     our ( $oid, $result, $status, $returnstring );
@@ -143,28 +93,7 @@
     return $result;
 }
 
-# Create the SNMP session
-( $s, $e ) = Net::SNMP->session(
-    -community => $community,
-    -hostname  => $hostname,
-    -version   => $version,
-    -timeout   => $timeout,
-    -port      => $port,
-);
-
 if ( !defined( $s->get_request($oid_testoid) ) ) {
-
-    # If we can't connect using SNMPv1 lets try as SNMPv2c
-    $s->close();
-    sleep 0.5;
-    $version = "2c";
-    ( $s, $e ) = Net::SNMP->session(
-        -community => $community,
-        -hostname  => $hostname,
-        -version   => $version,
-        -timeout   => $timeout,
-        -port      => $port,
-    );
     if ( !defined( $s->get_request($oid_testoid) ) ) {
         print "Agent not responding, tried SNMP v1 and v2\n";
         exit 1;

_______________________________________________
Opsview-checkins mailing list
Opsview-checkins@lists.opsview.org
http://lists.opsview.org/lists/listinfo/opsview-checkins

Reply via email to