Title: [opsview] [13340] Add tests for interfaces submission and hide buttons for demo user
- Revision
- 13340
- Author
- tvoon
- Date
- 2013-08-16 14:24:55 +0100 (Fri, 16 Aug 2013)
Log Message
Add tests for interfaces submission and hide buttons for demo user
Modified Paths
Modified: trunk/opsview-web/root/admin/host/interfaces
===================================================================
--- trunk/opsview-web/root/admin/host/interfaces 2013-08-16 13:16:54 UTC (rev 13339)
+++ trunk/opsview-web/root/admin/host/interfaces 2013-08-16 13:24:55 UTC (rev 13340)
@@ -57,9 +57,11 @@
<div class="action" _onclick_="queryhost({useHost:1,url:'[% c.uri_for("/admin/host/query_host", object.id).path | escape_js_string %]'})">[% c.loc("ui.admin.host.edit.action.queryHost") | html %]</div>
[% indicator_icon( { id => "query_host_indicator" } ); %]
<br />
+[% IF user_has_save_access %]
<div class="formButtons">
<input type="submit" value="[% c.loc("ui.state.downtime.button.submit") | html %]" class="right"/>
</div>
+[% END %]
<br clear="right"/>
<div id="snmp_info">
[% INCLUDE "snmpinterfaces" %]
Modified: trunk/opsview-web/root/admin/host/snmpinterfaces
===================================================================
--- trunk/opsview-web/root/admin/host/snmpinterfaces 2013-08-16 13:16:54 UTC (rev 13339)
+++ trunk/opsview-web/root/admin/host/snmpinterfaces 2013-08-16 13:24:55 UTC (rev 13340)
@@ -152,9 +152,11 @@
[% IF duplicate_help %]
<p class="crit_text">* [% c.loc("ui.admin.host.edit.interfaces.critical.duplicateNames") | html %] <a href="" c.config.help_url %]host#snmp_interfaces">[% c.loc("ui.messages.seeDocumentation") | html %]</a></p>
[% END %]
+[% IF user_has_save_access %]
<div class="formButtons">
<input type="submit" value="[% c.loc("ui.state.downtime.button.submit") | html %]" class="right"/>
</div>
+[% END %]
[% ELSE %]
[% IF ! testconnection %]
<span class="error_ignoreable">[% c.loc("ui.admin.host.edit.interfaces.noInterfacesFound") | html %]</span>
Modified: trunk/opsview-web/t/720acl.t
===================================================================
--- trunk/opsview-web/t/720acl.t 2013-08-16 13:16:54 UTC (rev 13339)
+++ trunk/opsview-web/t/720acl.t 2013-08-16 13:24:55 UTC (rev 13340)
@@ -91,6 +91,12 @@
$demo->post( "/admin/host/save_new", { cloned_from => 1 } );
is( $demo->status, 403, "Blocked code since no CONFIGURESAVE" );
+$demo->get_ok( "/admin/host/interfaces/7", "Can get interfaces page" );
+$demo->content_lacks( "formButtons", "Missing form submit buttons correctly" );
+$demo->form_name( "main_form" );
+$demo->submit_form;
+is( $demo->status, 403, "Got correct access denied" );
+
$demo->get_ok( "/logout" );
log_in( $demo, 'demo', 'demo' );
$demo->get_ok( "/user/preference",
_______________________________________________
Opsview-checkins mailing list
Opsview-checkins@lists.opsview.org
http://lists.opsview.org/lists/listinfo/opsview-checkins
