Sure thing, I'll look at the others as well. I meant to say federatedx BTW not federated, I saw the readme. Also I meant reset() not disconnect()! (oops)
On 18/06/14 18:39, Arjen Lentz wrote: > Oops I intended to send to list. > > > Hi Andrew > >> Arjen Lentz <ar...@openquery.com.au> wrote: >>> You may need some advice on how to ensure that when a connection closes, >>> things get cleaned up properly. We may have missed a hook of some sort. >>> You could also check this in another engine. Perhaps Federated, or >>> Spider, or CONNECT ? > > On 18/06/14 19:03, Andrew McDonnell wrote: >> From a very cursory look at federated it seems we dont have >> `handler::disconnect()` so I'll probably start there. >> Meantime in the medium term I think refactoring ha_oqgraph.cc >> to look more like ha_federated would be a worthwhile activity > > Federated is probably not the best example. > It's in the best case a fixed up version of something quite old. > Look at others also (CONNECT is the newest, but Spider also - and > perhaps TokuDB ?) and roughly document which we can then run by Serg and > others first. > This also provides the opportunity to get other people in the community > involved in some of the refactoring work, which has the advantage of > getting more people familiar with the codebase! > > > Regards, > Arjen. -- Mailing list: https://launchpad.net/~oqgraph-dev Post to : oqgraph-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~oqgraph-dev More help : https://help.launchpad.net/ListHelp
