On Tue, Jan 13, 2009 at 05:16:06PM -0500, Roger Dingledine wrote: > On Tue, Jan 13, 2009 at 12:26:15PM -0800, Christopher Davis wrote: > > I'm working on a patch to enable SOCKS 4 and 5 support for > > Tor's OR and directory connections. I got SOCKS working for OR > > connections already, but the directory behavior is a bit more > > challenging to SOCKSify, because it queues the request immediately > > on the connection's outbuf with the directory_send_command() call > > right after connecting in directory_initiate_command_rend(). To > > get SOCKS to work, the parameters (resource, payload, etc) would > > need to be saved to the connection structure so > > directory_send_command() can be called after the proxy handshake > > finishes. Would that be acceptable? > > Since Tor has moved towards doing the directory fetches over an OR > connection (it even does it by default in Tor 0.2.0.x and later), > I would suggest that you don't actually need to support socks proxies > for directory fetches. > > --Roger
I'll leave directory.c alone, then. Is there any reason why Tor needs to support direct directory fetches at this point? Perhaps the code could be simplified a bit. -- Christopher Davis
