On Tue, Feb 10, 2009 at 12:33:50PM -0600, Scott Bennett wrote: > On Tue, 10 Feb 2009 12:22:57 -0600 (CST) I wrote: > > I think we need a quick patch for this one. I just built and fired up > >0.2.1.12-alpha with no changes to torrc from what I had already. As soon > >as exit requests came in, I saw (at INFO-level logging) that IP addresses are > >now being logged as the exit connections are made, whereas in 0.2.1.7-alpha > >and earlier, the port numbers appeared, but the IP addresses had been > >scrubbed. > >I tried adding "SafeLogging 1" to torrc in case the default had somehow > >gotten > >changed, but that seemed to have no effect either. > > Here's more information. The "[scrubbed]" field still appears in the > messages, but the IP addresses now appear inside parentheses right after > the port number used. For example, > > Feb 10 11:43:05.346 [info] connection_edge_finished_connecting(): Exit > connection to [scrubbed]:43 (81.91.170.6) established. > > Unless what looks scary is somehow actually innocuous, I do think we > need a patch ASAP.
This looks like the offending message: --- src/or/connection_edge.c.orig 2009-02-10 11:20:48.000000000 -0800 +++ src/or/connection_edge.c 2009-02-10 11:21:05.000000000 -0800 @@ -328,9 +328,9 @@ conn = TO_CONN(edge_conn); tor_assert(conn->state == EXIT_CONN_STATE_CONNECTING); - log_info(LD_EXIT,"Exit connection to %s:%u (%s) established.", - escaped_safe_str(conn->address),conn->port, - fmt_addr(&conn->addr)); + log_info(LD_EXIT,"Exit connection to %s:%u established.", + escaped_safe_str(conn->address),conn->port); + conn->state = EXIT_CONN_STATE_OPEN; connection_watch_events(conn, EV_READ); /* stop writing, continue reading */ -- Christopher Davis
