Hi Patrick,
On Oct 23, 2009, at 13:00 , Patrick Ohly wrote:
On Fri, 2009-10-23 at 10:33 +0100, Patrick Ohly wrote:
Is the intended meaning really
"itemcount<(getDSConfig()->fMaxItemsPerMessage==0)" (comparison
against
0 or 1, the current interpretation of the code) or is it
"itemcount<getDSConfig()->fMaxItemsPerMessage" (a normal comparison
of
two counts)?
I've changed it to the later in the moblin.org "master" branch. I also
fixed all other "gcc -Werror -Wall" problems.
Ooops... Of course, your're perfectly right. That extra ==0 looks
very very much like a cut&paste accident, and also like a feature
nobody really used. I remember for whom that item count limit was
added, and it's very likely they only requested but never tested it. I
didn't neither :-(
Thanks for fixing that now!
Best Regards,
Lukas Zeller ([email protected])
-
Synthesis AG, SyncML Solutions & Sustainable Software Concepts
[email protected], http://www.synthesis.ch
_______________________________________________
os-libsynthesis mailing list
[email protected]
http://lists.synthesis.ch/mailman/listinfo/os-libsynthesis
