Hi Patrick, looks ok to me except that readConnectHost() should also be updated to avoid change of semantics (must still return host:port).
Best Regards, Lukas On Mar 7, 2012, at 14:36 , Patrick Ohly wrote: > On Tue, 2012-03-06 at 20:19 +0100, Lukas Zeller wrote: >> Hi Patrick, >> >> On Mar 6, 2012, at 14:55 , Patrick Ohly wrote: >> >>> Is there some utility code for decoding an URI into its individual >>> parts? >> >> Yes, it's called splitURL in sysync_utils.h/.cpp >> >>> Simple string operations don't work for an uri like this: >>> >>> file:///tmp/abc%25def => file:// + /tmp/abc%def >> >> splitURL in its current state cannot do that correctly either. >> However, I agree it would make sense to enhance it rather than >> creating a new function. > > Attached is my attempt on doing that. Does that look right? > > -- > Best Regards, Patrick Ohly > > The content of this message is my personal opinion only and although > I am an employee of Intel, the statements I make here in no way > represent Intel's position on the issue, nor am I authorized to speak > on behalf of Intel on this matter. > > <0001-scripting-file-URI-decoding.patch> _______________________________________________ os-libsynthesis mailing list [email protected] http://lists.synthesis.ch/mailman/listinfo/os-libsynthesis
