Hello Patrick, On 30.04.2014, at 19:10, Patrick Ohly <patrick.o...@intel.com> wrote:
>> What you have here is probably the most elaborate profile ever
>> specified for libsynthesis :-) , but I see no reason why it should not
>> work once the <position> is correct.
>
> That's what I had tried earlier. It leads to the situation where the
> labels of independent properties overwrite labels of other, earlier
> properties.
What do you mean by "independent" properties?
> That's because the position checking seems to focus
> exclusively on property values and ignores property parameters.
Yes.
Somehow I don't see how a label parameter value can get stored without also
writing an associated property value.
Only when using the grouped tag mode with a separate X-ABLabel property, it
might happen that you only have the label, but not (yet) the values, depending
on the order of the group members in the vCard.
Only if you mix both variants in the input vCard, I can imagine something like
the following could go wrong:
A.X-ABLabel:labelA
TEL;X-ABLabel=labelTel:123456789
A.TEL:987654321
In this case there is a label-only situation after the first line is parsed.
When the second line is parsed, it will overwrite the first label (because it
does not check the parameter array for being empty at that index), so labelA
would be lost.
But if I understood correctly, you are not mixing these two variants.
> Do I need to modify the source code to ensure that parameters do not
> exist yet?
Yes - however I'm not sure if NOT checking the parameters was just lazyness on
my part (from the assumption that a parameter-only property does not make sense
anyway) or a intentional thing. Right now, I can't imagine a case where
checking parameters would break previously intended behaviour, but then, I've
probably forgotten many of the nasty vCard corner cases I had to deal with...
> Similar to "for (sInt16 e=0; e<aPropP->numValues; e++) {" the code would
> also need to iterate over aPropP->parameterDefs.
Yes.
Best Regards,
Lukas
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ os-libsynthesis mailing list os-libsynthesis@synthesis.ch http://lists.synthesis.ch/mailman/listinfo/os-libsynthesis
