I just think that if it's a prereq, put it in prereqs, if it's a package, put it in packages - this prevents future confusion.
Perhaps Erich may have opinion on this. Cheers, Bernard > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Friday, May 19, 2006 16:33 > To: Bernard Li > Cc: [EMAIL PROTECTED]; [email protected] > Subject: RE: [Oscar-devel] RE: [Oscar-checkins] r4801 - in > trunk: lib/OSCAR packages/oda packages/oda/scripts share/prereqs > > So, you mean that let's suppose that oda is not one of OSCAR > packages any > more. We don't need the oda data in "Packages" table because > it is not a > package. Right. > But is it better to have it on prereqs? > We already set it up on packages. It was easier for me to > combine them to > packages because package_config_xmls_to_database needs to be > modified if > oda is not a package any more. :-) > > Anyways, if having oda as a prereqs is better and clearer, I > will move it > to prereqs. > > Regards, > > > > > Once oda becomes a prereq, I don't think it's necessary to > insert any > > package data into the "Packages" table - the important goal > of a prereq > > is to make sure that the listed prereq RPMs are installed during the > > install_prereq step, which is all you need to do. > > > > Cheers, > > > > Bernard > > > >> -----Original Message----- > >> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > >> Sent: Friday, May 19, 2006 16:04 > >> To: Bernard Li > >> Cc: DongInn Kim; [email protected] > >> Subject: RE: [Oscar-devel] RE: [Oscar-checkins] r4801 - in > >> trunk: lib/OSCAR packages/oda packages/oda/scripts share/prereqs > >> > >> Bernard, > >> > >> What file should I look at? > >> For example, are you talking about share/prereqs/base/prereq.cfg? > >> > >> But what I am talking about config.xml is inserting the oda > >> package data > >> to "Packages" table. > >> > >> How am I going to insert oda package data to "Packages" > table through > >> prereq.cfg? > >> > >> Am I missing something? > >> > >> Regards, > >> > >> > Hi DongInn: > >> > > >> > You should be able to convert oda's config.xml to > >> prereq.cfg - just look > >> > at any of the prereqs for examples. > >> > > >> > Cheers, > >> > > >> > Bernard > >> > > >> >> -----Original Message----- > >> >> From: DongInn Kim [mailto:[EMAIL PROTECTED] > >> >> Sent: Friday, May 19, 2006 14:45 > >> >> To: Bernard Li > >> >> Cc: [email protected] > >> >> Subject: Re: [Oscar-devel] RE: [Oscar-checkins] r4801 - in > >> >> trunk: lib/OSCAR packages/oda packages/oda/scripts share/prereqs > >> >> > >> >> Hi Bernard, > >> >> > >> >> Yes, I could've moved oda to share/prereqs/ if we can handle > >> >> config.xml for oda when it is moved to share/prereqs/. > >> >> The package oda is not really required to be > installed before all > >> >> the other stuffs (except for installing packages). We > can tell that > >> >> oda is still pre-required for all the other OSCAR > packages but not > >> >> for all the OSCAR installations. Even more, oda package does > >> >> not have > >> >> to run the prereqs oda work out of oda package. > >> >> > >> >> Now oda is just working fine on /packages doing the > >> prereqs works at > >> >> the same place. > >> >> > >> >> Maybe, if we can figure out how to handle the config.xml of > >> >> oda, then > >> >> let's try to move it to prereqs. > >> >> > >> >> Regards, > >> >> > >> >> - DongInn > >> >> > >> >> On May 19, 2006, at 5:14 PM, Bernard Li wrote: > >> >> > >> >> > If oda is a prereq, why is it in packages? Perhaps the better > >> >> > route is > >> >> > to move everything from packages -> prereqs? > >> >> > > >> >> > Cheers, > >> >> > > >> >> > Bernard > >> >> > > >> >> >> -----Original Message----- > >> >> >> From: [EMAIL PROTECTED] > >> >> >> [mailto:[EMAIL PROTECTED] On Behalf > >> >> >> Of [EMAIL PROTECTED] > >> >> >> Sent: Friday, May 19, 2006 14:09 > >> >> >> To: [EMAIL PROTECTED] > >> >> >> Subject: [Oscar-checkins] r4801 - in trunk: lib/OSCAR > >> >> >> packages/oda packages/oda/scripts share/prereqs > >> >> >> > >> >> >> Author: dikim > >> >> >> Date: 2006-05-19 17:09:10 -0400 (Fri, 19 May 2006) > >> >> >> New Revision: 4801 > >> >> >> > >> >> >> Added: > >> >> >> trunk/packages/oda/SRPMS/ > >> >> >> trunk/packages/oda/distro/ > >> >> >> trunk/packages/oda/prereq.cfg > >> >> >> trunk/packages/oda/scripts/oscar_table.sql > >> >> >> trunk/packages/oda/scripts/setup > >> >> >> Removed: > >> >> >> trunk/share/prereqs/oda/ > >> >> >> Modified: > >> >> >> trunk/lib/OSCAR/Database.pm > >> >> >> trunk/share/prereqs/prereqs.order > >> >> >> Log: > >> >> >> Move all the oda stuff on /share/prereqs to /packages/oda > >> >> >> > >> >> >> > >> >> >> Modified: trunk/lib/OSCAR/Database.pm > >> >> >> > >> =================================================================== > >> >> >> --- trunk/lib/OSCAR/Database.pm 2006-05-19 19:42:57 UTC > >> >> >> (rev 4800) > >> >> >> +++ trunk/lib/OSCAR/Database.pm 2006-05-19 21:09:10 UTC > >> >> >> (rev 4801) > >> >> >> @@ -451,7 +451,7 @@ > >> >> >> sub create_table { > >> >> >> my ($options_ref, $error_strings_ref) = @_; > >> >> >> > >> >> >> - my $sql_dir = "$ENV{OSCAR_HOME}/share/prereqs/oda"; > >> >> >> + my $sql_dir = "$ENV{OSCAR_HOME}/packages/oda/scripts"; > >> >> >> my $sql_file = "$sql_dir/oscar_table.sql"; > >> >> >> > >> >> >> print "DB_DEBUG>$0:\n====> in Database::create_table > >> >> >> uses the SQL statement which are already defined at > >> >> >> $sql_file" if $$options_ref{verbose}; > >> >> >> > >> >> >> Copied: trunk/packages/oda/SRPMS (from rev 4797, > >> >> >> trunk/share/prereqs/oda/SRPMS) > >> >> >> > >> >> >> Copied: trunk/packages/oda/distro (from rev 4797, > >> >> >> trunk/share/prereqs/oda/distro) > >> >> >> > >> >> >> Copied: trunk/packages/oda/prereq.cfg (from rev 4797, > >> >> >> trunk/share/prereqs/oda/prereq.cfg) > >> >> >> > >> >> >> Copied: trunk/packages/oda/scripts/oscar_table.sql (from rev > >> >> >> 4797, trunk/share/prereqs/oda/oscar_table.sql) > >> >> >> > >> >> >> Copied: trunk/packages/oda/scripts/setup (from rev 4797, > >> >> >> trunk/share/prereqs/oda/scripts/setup) > >> >> >> > >> >> >> Modified: trunk/share/prereqs/prereqs.order > >> >> >> > >> =================================================================== > >> >> >> --- trunk/share/prereqs/prereqs.order > 2006-05-19 19:42:57 UTC > >> >> >> (rev 4800) > >> >> >> +++ trunk/share/prereqs/prereqs.order > 2006-05-19 21:09:10 UTC > >> >> >> (rev 4801) > >> >> >> @@ -11,7 +11,7 @@ > >> >> >> share/prereqs/update-rpms > >> >> >> share/prereqs/perl-XML-Parser > >> >> >> share/prereqs/perl-XML-Simple > >> >> >> -share/prereqs/oda > >> >> >> +packages/oda > >> >> >> share/prereqs/perl-HTML-Tree > >> >> >> share/prereqs/perl-Tk > >> >> >> share/prereqs/perl-Qt > >> >> >> > >> >> >> > >> >> >> > >> >> >> ------------------------------------------------------- > >> >> >> Using Tomcat but need to do more? Need to support web > >> >> >> services, security? > >> >> >> Get stuff done quickly with pre-integrated technology to make > >> >> >> your job easier > >> >> >> Download IBM WebSphere Application Server v.1.0.1 based on > >> >> >> Apache Geronimo > >> >> >> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&; > >> >> >> dat=121642 > >> >> >> _______________________________________________ > >> >> >> Oscar-checkins mailing list > >> >> >> [EMAIL PROTECTED] > >> >> >> https://lists.sourceforge.net/lists/listinfo/oscar-checkins > >> >> >> > >> >> > > >> >> > > >> >> > ------------------------------------------------------- > >> >> > Using Tomcat but need to do more? Need to support web > services, > >> >> > security? > >> >> > Get stuff done quickly with pre-integrated technology to > >> make your > >> >> > job easier > >> >> > Download IBM WebSphere Application Server v.1.0.1 > based on Apache > >> >> > Geronimo > >> >> > http://sel.as-us.falkag.net/sel? > >> >> > cmd_______________________________________________ > >> >> > Oscar-devel mailing list > >> >> > [email protected] > >> >> > https://lists.sourceforge.net/lists/listinfo/oscar-devel > >> >> > >> >> > >> > > >> > >> > > > > ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642 _______________________________________________ Oscar-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oscar-devel
