Olivier, Your patch is in after minor modifications. Thanks for your contribution.
I also advice you to create your patch from the trunk branch and not the version on your system, that will avoid patch merging issues. I will try to release a new version of SystemInstaller later today. Regards, ----- "Olivier LAHAYE" <olivier.lah...@cea.fr> a écrit : > Geoffroy, > > Here is the latest version of my patch for IA.pm against > systeminstaller-oscar-2.4.8-1 rpm > It adds full support for GPT partition table in *.disk files > (label_type=gpt in the header of *.disk file) > It works with /dev/hd* /dev/sd* and /dev/cciss/c#d#p# partition naming > scheme. > It adds more checks for bad msdos partitions layout. > > I've successfully tested so far the following configurations: > - ide.disk, scsi.disk, cciss.disk with and without label_type=gpt > - *.disk with: > - 4 primary and at least one logical partitions (hda1 hda2 hda3 hda4 > and hda5 => not possible: correctly detected) > - 4 primary with no logical or extended => works > - extended partitions in non ascending order (hda6 hda5 hda7) => > created in correct order with correct parameters > - extended partitions that are not contiguous (hda5 hda7, no hda6) => > correctly detected => die > - more than one partition with size set to "*" > > One potential problem that is remaining, but not related to oscar: > case were hda6 size=* and hda7 size=512. i think that > si_mkautoinstallscript from systeminstaller may be not enough > sophisticated to handle size(hda6) = freespace(disk)-size(hda7) [I may > be wrong on that point] > (hda7 cannot be created before hda6 as it is an extended partition). > > Regards, > > Olivier. > > Le samedi 28 novembre 2009 00:21:12, vous avez écrit : > > Olivier, > > > > The idea is very interesting, can you tell me which cases you > actually tested (at least CCISS i guess)? I do not have the time to do > any testing right now so i just want to know what is the actually > status of the patch before to check in it (i hope it is ok with you). > > > > Thanks, > > > > ----- "Olivier LAHAYE" <olivier.lah...@cea.fr> a écrit : > > > > > Hi, > > > > > > I've modified IA.pm from systeminstaller-oscar-2.4.8-1 to as > support > > > for GPT partition tables and fix CCISS HP Raid Array as well. > > > > > > After a few tests, it seems that it works realy well.:-) > > > > > > As I'm a perl newbee, there is a strangeness that I don't > understand, > > > it seems that the 3 last parameters recieved by do_partition are > > > references. Thus I need to address them using $$, and I don't > > > understand why, aside that, every thing seems good. > > > > > > Regards, > > > > > > > -- > Olivier LAHAYE > CEA Saclay > DRT-LIST-DETECS-SSTM > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 > 30-Day > trial. Simplify your report design, integration and deployment - and > focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Oscar-devel mailing list > Oscar-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/oscar-devel ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Oscar-devel mailing list Oscar-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oscar-devel
