Olivier,

I cannot accept the patch because:
- the patch duplicates existing code (cf. OSCAR::Network),
- you execute SQL command directly while it should be hidden behind ODA.

I will try to rework your patch to make it acceptable.

Regards,

----- "Olivier LAHAYE" <olivier.lah...@cea.fr> a écrit :

> Oups, small artifact.
> This is now the correct partch :-)
> 
> I've tested alone and from an oscar-setup -t oscar-setup --bootstrap
> It seems ok.
> 
> Le mardi 1 décembre 2009 17:07:35 Olivier LAHAYE, vous avez écrit :
> > 
> > Hi,
> > 
> > This patch fix oscar database bootstrapping.
> > 
> > This is a fix to the command
> /usr/bin/create_and_populate_basic_node_info.
> > 
> > Now:
> > - The Nics table is populated with informations regarding
> OSCAR_NETWORK_INTERFACE.
> > - The Networks table is populated with network related to this
> interface.
> > 
> > The table clusters still lack a default value for install_mode.
> Maybe the stage 6 will initialize it. I'll check later.
> > 
> > Sorry, patch is against normal package as I'm lost in the svn. :)
> > 
> > Best regards,
> > 
> > Olivier.
> > 
> 
> -- 
>       Olivier LAHAYE
>       CEA Saclay
>       DRT-LIST-DETECS-SSTM
> 
> ------------------------------------------------------------------------------
> Join us December 9, 2009 for the Red Hat Virtual Experience,
> a free event focused on virtualization and cloud computing. 
> Attend in-depth sessions from your desk. Your couch. Anywhere.
> http://p.sf.net/sfu/redhat-sfdev2dev
> _______________________________________________
> Oscar-devel mailing list
> Oscar-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oscar-devel

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Oscar-devel mailing list
Oscar-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oscar-devel

Reply via email to