Geoffroy,
db_type is /etc/oscar/oscar.conf:ODA_TYPE. Values can be either "file" or "db"
/etc/oscar/oscar.conf:DB_TYPE is simply LOST. Values can be: mysql, pgsql or
ant other future engines supported.
More over this variable is misleading and should be renamed DB_ENGINE. But in
order to avoid rewrite code and avoid problems, I did not change it.
My patch was meant to avoid ugly stuffs in the code like $ENV{OSCAR_DB} to
retrieve the name of the database engine (as it is not read by configurator)
Because it is difficult to have this information, many pieces of code have
mysql hardcoded in it.
Another clean and optimal solution could be to use ODA_TYPE with values: file,
mysql, pgsql, ...
But this implies to rewrite some code: if ($config->{db_type} eq "db") should
be replaced by if !($config->{db_type} eq "file")
I personally would prefer this solution.(and I can review code for it).
Just tell me.
Regards,
Olivier.
Le mercredi 2 décembre 2009 19:31:27, vous avez écrit :
> Olivier,
>
> What is the db_type and how is it different from the db_engine?
>
> With db_type you can already defint MYSQL vs. prosgresql and so on...
>
> Regards,
>
> ----- "Olivier LAHAYE" <olivier.lah...@cea.fr> a écrit :
>
> > adds $db_engine in configmanager so we can avoid hardcoding of mysql.
> >
>
--
Olivier LAHAYE
CEA Saclay
DRT-LIST-DETECS-SSTM
------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Oscar-devel mailing list
Oscar-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oscar-devel
