Hi Geoffroy, I did the change for the new syntax as it'll ease support in the future (no more patches between distros). ENGINE= is supported in MySQL since v4.0.18 and TYPE was introduced in 3.23.0, the 1st MySQL version integrating multiple database engines. I though that Next version of Oscar was supposed to be installed on OS that had at least a MySQL newer than 4.0.18 (RHEL-4.8 is using 4.1.22 and is already EOL for example) wich seems not to be true. Note: TYPE is deprecated since v5.0 and not supported since 5.5.
Instead of patching all debian systems to force the old syntax, can't you patch only for debian that have a mysql older than 4.0.18? Did debian disabled the recommanded ENGIN= syntax for mysql newer than 4.0.17? Best Regards, -- Olivier LAHAYE CEA DRT/LIST/DCSI/DIR ________________________________________ De : geoffroy.val...@free.fr [geoffroy.val...@free.fr] Date d'envoi : jeudi 31 janvier 2013 22:40 À : oscar-devel@lists.sourceforge.net Objet : Re: [Oscar-devel] oda - r9543 partially breaks the Debian support I fixed the problem on all Debian based systems, which did not revert the check-in: 1/ I assumed the modification made in r9541 was the reference (new syntax), 2/ for old Debian based systems, i patch the oscar_table.sql file to fall back to the old syntax. Is it ok if i release a new version of ODA that includes all these modifications? That will allow me to have a convenient snapshot of that version of the upcoming deployment of Debian clusters that i will have to deal with. If nobody speaks up before Monday, i will assume it is ok. Thanks, ----- Mail original ----- De: "geoffroy vallee" <geoffroy.val...@free.fr> À: oscar-devel@lists.sourceforge.net Envoyé: Jeudi 31 Janvier 2013 15:10:55 Objet: Re: [Oscar-devel] oda - r9543 partially breaks the Debian support My apologies, you actually included the MySQL version number in the ChangeLog (which by the way is absolutely _not_ the right place to put this kind of information). It seems this is still creating problem on some Debian systems so the rest of the email is still valid. ----- Mail original ----- De: "geoffroy vallee" <geoffroy.val...@free.fr> À: oscar-devel@lists.sourceforge.net Envoyé: Jeudi 31 Janvier 2013 15:05:42 Objet: [Oscar-devel] oda - r9543 partially breaks the Debian support I am reverting r9541, this is partially breaking the Debian support: the supported syntax totally depends on the version of MySQL provided by the Linux distribution. Assuming that because it works for most CentOS releases is an absolutely wrong "validation test", especially if the version number of MySQL is not provided for comparison between Linux distributions. Furthermore, I implemented a work-around for Ubuntu (Ubuntu 12.10 is facing the same issue), which typically patches the oscar_table.sql during the creation of the Debian package. The ChangeLog explicitly reference this modification; it is therefore obvious that you did not try to see what was done before and decided to implement a conflicting solution without discussion. I will also appreciate if you could stop including negative comments in your check-ins such as "all other scripts are useless and ignored", especially when it is not related to the actual check-in. If you have a problem with a piece of code, you bring the problem on the developer mailing list (here) and we find a solution as a group. Negative criticisms in SVN log never fixed any problem and only create frustration to other developers. Thanks, ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ Oscar-devel mailing list Oscar-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oscar-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ Oscar-devel mailing list Oscar-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oscar-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ Oscar-devel mailing list Oscar-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oscar-devel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ Oscar-devel mailing list Oscar-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/oscar-devel
