Frank,

Thank you very much for finding the bugs!  I'm surprised that they haven't
come up before.  But then again, not too many people acutally use the
kernel_picker and I can debug just so many setups here.

>> On 27 Aug 2003, Frank Crawford <[EMAIL PROTECTED]> wrote:
> Folks,
>       I've found two different problems with the kernel_picker scripts which
> affect the use of multiple images.  The first is that if there are
> multiple images available, the script
> "/opt/oscar/packages/kernel_picker/scripts/post_clients" does not have
> any option to select which image to use, and causes the kernel_picker.pl
> script to prompt for selection, in a way that cannot be responded to. 
> The fix for this is to pass the image option to
> "/opt/kernel_picker/bin/kernel_picker.pl" the option "-oscarimage
> image".  (However, I'm not sure how to find the image to pass.)

As a 'quick fix', I have added a command line option to kernel_picker
called '--autoselectimage':

       In the event that there are two or more OSCAR image directories
       but you do not want to have to specify one via the '--oscarimage'
       option (e.g. when you want to call kernel_picker from another
       program), use this option.  (The first OSCAR image directory,
       alphabetcially ignoring case, will be used.)  Otherwise, you will
       be presented with a list of OSCAR image directories and be asked
       to choose one to use.

This will at least make post_clients work without pausing for user
interaction.  

I think another possible solution is to display a list of OSCAR images in
kernel_picker's Configurator and make the user choose one.  That shouldn't
be too difficult to add to pre_configure.  I'll look into it.  If the user
doesn't want to select an OSCAR image (for whatever reason), kernel_picker
can still use the '--autoselectimage' option, so I think it's a useful
command line option to have.

>       Secondly, if the option "-oscarimage" is passed to
> "/opt/kernel_picker/bin/kernel_picker.pl", it fails to correctly look up
> the image directory correctly.  A patch for this is below:
> 
> --- kernel_picker.pl.dist       2003-02-07 08:10:16.000000000 +1100
> +++ kernel_picker.pl    2003-08-27 13:12:10.000000000 +1000
> @@ -337,7 +337,7 @@
>    # Check for a valid command line option first
>    if ($opt_oscarimage ne "")
>      {
> -      if (-d $systemimagesdir . $opt_oscarimage)
> +      if (-d $systemimagesdir . '/' . $opt_oscarimage)
>          { # User entered a valid oscar image on the command line
>            $oscarimagename = $opt_oscarimage;
>            return $oscarimagename;

Thanks for finding that one.  I have added it to kernel_picker.

> Thanks
> Frank

I have uploaded the changed files to CVS (which you can get from the OSCAR
project page at http://sourceforge.net/projects/oscar/) and I have also
posted the latest version of kernel_picker on NCSA's OSCAR page at
http://oscar.ncsa.uiuc.edu/ .  Both an RPM and a tarball are available.

Thanks again for the help and please let me know if there are any problems
with the changes I made.

Terry Fleury
[EMAIL PROTECTED]



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Oscar-users mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/oscar-users

Reply via email to