Hi,

the attached patch fixes the follwowing two server install step breakages.

==========

Looking for /var/lib/oscar/packages/netbootmgr/post_server_install...
Looking for /var/lib/oscar/packages/netbootmgr/post_server_rpm_install...
Looking for /var/lib/oscar/packages/ntpconfig/server-post-install...
Looking for /var/lib/oscar/packages/ntpconfig/server-post_install...
--> About to run /var/lib/oscar/packages/ntpconfig/server-post_install for ntpconfig Not enough arguments for OSCAR::Database::get_headnode_iface at /var/lib/oscar/packages/ntpconfig/server-post_install li
ne 40, near "()"
Execution of /var/lib/oscar/packages/ntpconfig/server-post_install aborted due to compilation errors. ERROR: /var/lib/oscar/packages/ntpconfig/server-post_install exitted badly (255) at /usr/bin/install_server line 175 ERROR: Failed running post_server_install for ntpconfig at /usr/bin/install_server line 175.
--> Step 3: Failed to properly install OSCAR server; please check the logs

==========

Looking for /var/lib/oscar/packages/ntpconfig/server-post-install...
Looking for /var/lib/oscar/packages/ntpconfig/server-post_install...
--> About to run /var/lib/oscar/packages/ntpconfig/server-post_install for ntpconfig Undefined subroutine &main::readInConfigValues called at /var/lib/oscar/packages/ntpconfig/server-post_install line 63. ERROR: /var/lib/oscar/packages/ntpconfig/server-post_install exitted badly (29) at /usr/bin/install_server line 175 ERROR: Failed running post_server_install for ntpconfig at /usr/bin/install_server line 175.
--> Step 3: Failed to properly install OSCAR server; please check the logs

==========

the fix for the "get_headnode_iface($bla, $bla1);" issue is a crude hack and i am not proud of it. please improve it.

it works now though. tested on centos 5.3

kind regards
Thilo
Index: server-post-install
===================================================================
--- server-post-install (revision 8676)
+++ server-post-install (working copy)
@@ -23,7 +23,7 @@
 use lib "$ENV{OSCAR_HOME}/lib";
 use OSCAR::Network;
 use OSCAR::Database;
-use OSCAR::Configbox;
+use OSCAR::Configurator_backend;
 use Carp;
 
 my $ntpBuffer = "";
@@ -37,7 +37,9 @@
 $ntpd = "ntp" if -x "/etc/init.d/ntp";
 
 # get headnode's interface information from OSCAR database
-my $iface = get_headnode_iface();
+my $bla;
+my $bla1;
+my $iface = get_headnode_iface($bla, $bla1);
 
 open(CONF, $ntp_conf) or croak("Failed to open $ntp_conf");
 
@@ -58,7 +60,7 @@
 
 # User has configured ntpconfig package with a NTP server
 if (-e $configurator) {
-    $ref = readInConfigValues($configurator,"ntpconfig","",noarray=>1);
+    $ref = 
OSCAR::Configurator_backend::readInConfigValues($configurator,"ntpconfig","",noarray=>1);
     # If ntpconfig package has configured NTP server before, replace
     if ($ntpBuffer =~ /User selected NTP Server/) {
        $ntpBuffer =~ s/^server.*\nrestrict.*\n/server  
$ref->{ntpserver}\nrestrict $ref->{ntpserver} mask 255.255.255.255\n/m;
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Oscar-users mailing list
Oscar-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oscar-users

Reply via email to