On Wednesday 07 May 2014 18:45:25 Guillermo Rodriguez Garcia wrote: > 2014-05-07 18:33 GMT+02:00 Guillermo Rodriguez Garcia > > <[email protected]>: > > Hi all, > > > > I noticed that the serial driver for the s3c2440 does detect parity > > errors, but does not increment the corresponding error counter in the > > I correct myself. The driver currently does NOT properly detect parity > errors. Although it contains code to do so (!), this code is protected by > the following: > > if (unlikely(uerstat & S3C2410_UERSTAT_ANY)) { > ... > } > > And the definition of S3C2410_UERSTAT_ANY in include/linux/serial_s3c.h > does not include the parity bit. > > This means that the code that currently checks for parity errors in the > serial driver won't actually be run when a parity error occurs. This looks > like a bug (independent from the issue I was describing in my previous mail > related to the serial_icounter_struct structure). > > Can someone comment?
You should ask the maintainer(s) here: $ scripts/get_maintainer.pl -f drivers/tty/serial/samsung.c Greg Kroah-Hartman <[email protected]> (maintainer:SERIAL DRIVERS) Jiri Slaby <[email protected]> (supporter:TTY LAYER) [email protected] (open list:SERIAL DRIVERS) [email protected] (open list) Regards, Juergen -- Pengutronix e.K. | Juergen Borleis | Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
