Hi Guillermo,

On Thursday 29 May 2014 19:28:10 Guillermo Rodriguez Garcia wrote:
> The mini2440 BSP ships with a platform-specific /etc/fstab file
> which does not mount a tmpfs filesystem in /run. Options that
> expect a tmpfs in /run will not work as expected.
>
> This patch:
> - adds /run as a tmpfs
> - bind mounts /var/run to /run
> - bind mounts /var/tmp to /tmp
> - Adds noauto to debugfs
>
> Signed-off-by: Guillermo Rodriguez <[email protected]>

I tried your patch. But...

> ---
>
> diff --git a/configs/platform-friendlyarm-mini2440/projectroot/etc/fstab
> b/configs/platform-friendlyarm-mini2440/projectroot/etc/fstab
> index 22d061a..15464f4 100644
> --- a/configs/platform-friendlyarm-mini2440/projectroot/etc/fstab
> +++ b/configs/platform-friendlyarm-mini2440/projectroot/etc/fstab
> @@ -7,11 +7,13 @@ proc /proc proc defaults 0 0
>  devpts /dev/pts devpts defaults 0 0
>  none /tmp tmpfs defaults,mode=1777,uid=0,gid=0 0 0
   ^^^^^^^^^^^^^^^ here is a tmpfs..

>  none /sys sysfs defaults 0 0
> -debugfs /sys/kernel/debug debugfs defaults 0 0
> +debugfs /sys/kernel/debug debugfs defaults,noauto 0 0
>  usbfs /proc/bus/usb usbfs devgid=14,devmode=0660 0 0
>
>  # ramdisks
> +none /run tmpfs defaults,mode=0755,uid=0,gid=0 0 0
> +none /tmp tmpfs defaults,mode=1777,uid=0,gid=0 0 0
   ^^^^^^^^^^^^^^^ ...and you add another one

>  none /var/log tmpfs defaults,mode=0755,uid=0,gid=0 0 0
> -none /var/run tmpfs defaults,mode=0755,uid=0,gid=0 0 0
>  none /var/lock tmpfs defaults,mode=0755,uid=0,gid=0 0 0
> -none /var/tmp tmpfs defaults,mode=1777,uid=0,gid=0 0 0
> +/run /var/run bind bind 0 0
> +/tmp /var/tmp bind bind 0 0

On the other hand I checked the generic fstab from PTXdist itself and it seems 
it now does the job for us. So I would prefer to remove the BSP local fstab 
entirely instead of adapting it to current needs. Your opinion?

Regards,
Jürgen

-- 
Pengutronix e.K.                              | Juergen Borleis             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

Reply via email to