Hi Stephan,
On Saturday morning I merged your changes and checked them in, but the
stats collection and display wasn't complete - it only showed the
stats for a single view, rather than the whole viewer.
To fix this required a number of changes to osgViewer, rather than
tweak things I've gone for a wide set of changes to
Viewer/CompsiteViewer which involve factoring out the common API into
a ViewerBase class. Both Viewer and CompositeViewer subclass from
ViewerBase, and StatsHandler now handles ViewerBase rather than View.
I have just checked in all my changes. The stats handler is now
behaving much more consistently between Viewer and CompositeViewer
with all the stats bars/update etc stats appear as you'd expect. The
only issues left are :
1) The threading model is not reset by CompositeViewer in the same way as is
done by Viewer so the threading model just appears as AutomaticSelection.
I have some other threading work to do on CompositeViewer which will
do further unification of functionality w.r.t threading and this
will solve this
issue.
2) The XCode projects will now be broken with the introduction of
include/osgViewer/ViewerBase and src/osgViewer/ViewerBase.cpp. Could
you add these please.
Cheers,
Robert.
On 9/28/07, Stephan Maximilian Huber <[EMAIL PROTECTED]> wrote:
> Hi Robert,
>
> attached you'll find an enhanced version of the statshandler, so it
> works with the composite-viewer (and a modified
> osgcompositeviewer-example to test the code).
>
> * I refactored some code and moved some methods from Viewer to View
> (getCameras and getContexts)
> * I modified the stats-handler to accept osgViewer::View
> * i enhanced the composite-viewer-class to collect various statistics.
>
> known limitations:
> * most stats are not collected per view, they are collected per frame
> and distributed to attached views (fps, update and event)
> * no handling for the various threading-modes of composite-viewer, for
> now it displays "threading-mode: nunknown"
>
> I am not sure if I chose the right solution to add the hud-camera to a
> compositeviewer's view, you know the code better than I, please review
> this bit of code carefully.
>
> I hope you'll find the submission useful,
>
> thanks,
> Stephan
>
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
