Thanks Serge, changes now merged and submitted to SVN.

It would be worth polling the community to whether
OSG_MSVC_GENERATE_PLUGINS_AND_WRAPPERS_MANIFESTS should be ON of OFF
by default, my guess is OFF would be better.

On Dec 12, 2007 8:45 AM, Serge Lages <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Here is a modified version with your recommandations, the option is visible
> only for VS8 and is no more marked as advanced.
>
> Cheers,
>
>
>
> On Dec 11, 2007 6:01 PM, Robert Osfield < [EMAIL PROTECTED]> wrote:
> > Hi Serge,
> >
> > Would it be possible to reorganise your changes so that the options
> > only come up for the effected Windows platforms as the manifest option
> > setting you've gone for with this submission looks like it'll appear
> > on all platforms.  This would be confusing for end users.  Given the
> > above fix I'm not this option would need to be marked as advanced.
> >
> > Robert.
> >
> >
> >
> >
> > On Dec 11, 2007 10:29 AM, Serge Lages < [EMAIL PROTECTED]> wrote:
> > > It's better with the file attached... :p
> > >
> > >
> > >
> > > On Dec 11, 2007 11:28 AM, Serge Lages < [EMAIL PROTECTED]> wrote:
> > > > Hi Robert,
> > > >
> > > > Here is a new modification to CMake adding an option
> > > (OSG_MSVC_GENERATE_PLUGINS_AND_WRAPPERS_MANIFESTS) to specify if we want
> to
> > > generate or not the manifest files under VS8 for the plugins and the
> > > wrappers. It seems that the manifests are needed if we try to load
> > > dynamically a core OSG dll.
> > > >
> > > > By default the value is set to ON to follow the previous build
> behaviour.
> > > > Cheers,
> > > >
> > > > --
> > > > Serge Lages
> > > > http://www.tharsis-software.com
> > >
> > >
> > >
> > > --
> > > Serge Lages
> > > http://www.tharsis-software.com
> > > _______________________________________________
> > > osg-submissions mailing list
> > > [email protected]
> > >
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
> > >
> > >
> > _______________________________________________
> > osg-submissions mailing list
> > [email protected]
> >
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
> >
>
>
>
> --
>
>
> Serge Lages
> http://www.tharsis-software.com
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to