-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Robert Osfield wrote: > Thanks Paul, I'm not the original author of this line, but it looks > like your analysis and fix of the warning is correct. I do wonder > about moving this static method directly into osg::Texture though as > this is more appropriate place for it. > > On Dec 12, 2007 3:40 AM, Paul Martz <[EMAIL PROTECTED]> wrote: >> >> Function declaration returns a bool, function body was returning a pointer. >> Changed body to return (pointer != NULL). Not sure this is correct, but I >> assume it is. Yes, that's fine, or return texture->getTextureObject(contextID) != 0, depending on your style preference.
It would be fine with me if that, and the corresponding functions for StateSet, were moved into the classes. Also, I didn't do anything about shader programs and compilation, mostly because the pager doesn't either. Tim >> >> Paul Martz >> Skew Matrix Software LLC >> http://www.skew-matrix.com >> 303 859 9466 >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFHX6wCeDhWHdXrDRURAivDAKCQigrYuFKNFd5xYSCQxSI5bph8uwCeJ2pu WD/fTDDNmMoJq7EFqb6JQW4= =N8SM -----END PGP SIGNATURE----- _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
