Hi Serge,

I've just gone through your changes and they all look good are are now
checked in.

The only observation is that setFont method should probably be changed
to take a ref_ptr<> rather than a straight C pointer to remove the
need for the .get() when assigning the font.  This might open the door
to the possibility that the compiler would discard the temporary
ref_ptr<> passed back from the stack once it get the C pointer from
it, at this point the object could go out of scope.

Robert.

On Dec 12, 2007 3:28 PM, Serge Lages <[EMAIL PROTECTED]> wrote:
> Hi Robert,
>
> Here is the patch with the readRef* methods added to osgDB and osgText, and
> modifications to the databasepager and to the text making them use these
> methods. I've been running my test app during 3 hours now without any crash.
> I have also removed some warnings into the databasepager with signed versus
> unsigned comparisons.
>
> Cheers,
>
> --
> Serge Lages
> http://www.tharsis-software.com
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to