Thank You.

I am curious about my submittal of OSGA plugin modifications (sent in around 
10th of October). Did you reject this or its still in verification ?  If 
rejected I would like to hear whats wrong so I can made it right.

Cheers,
Wojtek Lewandowski

----- Original Message ----- 
From: "Robert Osfield" <[EMAIL PROTECTED]>
To: "OpenSceneGraph Submissions" <[email protected]>
Sent: Sunday, December 16, 2007 6:14 PM
Subject: Re: [osg-submissions] Crash in IVE plugin while 
writingosgSim::BlinkSequence


> Thanks Wojtek, fix merged and submitted to SVN.  Also made change so
> that SequenceGroup is only set up when baseTime!=0.
>
> On Dec 12, 2007 5:39 PM, Wojciech Lewandowski <[EMAIL PROTECTED]> 
> wrote:
>>
>>
>> Hi again,
>>
>> This is the last one for today ;-).
>>
>> osgSim::BlinkSequence has sequenceGroup unitialized by default (=NULL
>> ref_ptr). By looking at the code I figured out that unset sequenceGroup 
>> is
>> completely correct and thus allowed.
>>
>> But writing BlinkSequence with empty sequence group caused a crash when 
>> IVE
>> was accessing baseTime from NULL address.
>>
>> Atttached is a fix for this situation.
>>
>> I also thought about fixing BlinkSequence::read to be symmetrical to 
>> modifed
>> BlinkSequence::write. This change would not create sequenceGroup when
>> readDouble returned basetime equal 0.0. It would only create 
>> sequenceGroup
>> when base time was not zero. But decided to leave this for your decision.
>>
>> Cheers,
>> Wojtek
>> _______________________________________________
>> osg-submissions mailing list
>> [email protected]
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>
>>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
> 


_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to