Thanks John, changes all look good, now merged and submitted to SVN.
On Dec 20, 2007 4:48 PM, John Kelso <[EMAIL PROTECTED]> wrote: > Hi Robert, > > Attached is sequence.tar.gz, containing the file IveVersion.h and > Sequence.cpp from the directory OpenSceneGraph/src/osgPlugins/ive. > > Sequence.cpp now has checks for the version in IveVersion.h. The previous > version had no version checks at all. As the ive file changes just added > extra fields, the checks are of the sort: > > if (out->getVersion() >= VERSION_0022) > > and > > if (in->getVersion() >= VERSION_0022) > > IveVersion.h has an incremented version number; 21 used to be the highest, > now it's 22. > > I *think* this is what you had in mind from your email below, but I admit I > wasn't sure if you wanted me to use version 21, or increment and use 22. I > went for 22- hope that's right. > > Thanks, > > -John > > > On Fri, 14 Dec 2007, Robert Osfield wrote: > > > Hi John, > > > > I've already reviewed this submission, rejected it on grounds that it > > broke backwards/forwards compatibility due to not using versioned > > checks around the added code. Did you miss this reply? > > > > Have a search through the ive plugin for instances where the version > > number is used on read/write, as this will illustrate how > > compatibility is maintained. When adding new stuff on increments the > > IVE version number as well. > > > > Robert. > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
