Robert Osfield wrote: > Hi Zach, > > Could you explain what the problem you are addressing, and what > version of the OSG you are using. FYI, the intent of this code block > is deliberately to use -1 as the signifier that no screen number has > been specified, this way calling code can handle the case and is meant > to - typically it should just then default to 0 for the screen number > when its not defined to achieve your desired effect. If you have > code elsewhere that is failure because of this, then its this code > that is probably not working correctly, hence why I'd like to back out > and find out why you are needing this change.
The problem is that users who have DISPLAY=:0, which we believe is valid, can't start OSG applications that check the display value. They fail with a Error: Not able to create requested visual. message. I suppose the proper fix is to handle this case in GraphicsWindowX11.cpp. Tim > > Robert. > > On Dec 28, 2007 9:37 PM, Zach Welch <[EMAIL PROTECTED]> wrote: >> Howdy, >> >> The attached patch fixes the >> osg::GraphicsContext::ScreenIdentifier::setScreenIdentifier method to >> correctly default to the first screen for systems where `DISPLAY=:0'. >> >> Cheers, >> >> Zach Welch >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org -- Red Hat France SARL, 171 Avenue Georges Clemenceau 92024 Nanterre Cedex, France. Siret n° 421 199 464 00056 _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
